Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the unexecuted Tx verification at startup. Now, unexecuted Tx are executed.
I've put a zombies VM detection. I use the
client.is_alive()
like the current scheduler.From my test I see that zombies VM always return true to this call and stay running indefinitely using all the CPU. From the VM logs, the kernel has crashed, but it seems to still running.
They are stopped after the MAX_VM_RUN_TIME, but It takes time.
So the current implementation halt crashed VM only after the MAX_VM_RUN_TIME time. I didn't manage to have a VM that crash and doesn't seem alive.
I think to do a better Zombie detection we can implement 2 things:
get_task()
after a certain time. I didn't do the test, but it seems that the VM crash early.From my test, the number of zombie VM depends on the node CPU usage.
It's a raw implementation to test. I think we can dissociate the task scheduling part and the VM management part to simplify the loop and the VM (start/stop/zombie) management.