Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to encrypt and decrypt from stdin #1690

Merged
merged 4 commits into from
Mar 2, 2025
Merged

Allow to encrypt and decrypt from stdin #1690

merged 4 commits into from
Mar 2, 2025
+179 −58

Conversation

felixfontein
Copy link
Contributor

Allows to encrypt/decrpyt from stdin by providing no input filename to the encrpyt and decrpyt commands. For encrypt, --filename-override must be provided in that case to be able to select the proper creation rule.

Fixes #739
Ref: #1104

@felixfontein felixfontein added this to the 3.10.0 milestone Dec 1, 2024
@felixfontein felixfontein requested a review from a team December 1, 2024 12:45
@felixfontein felixfontein mentioned this pull request Dec 1, 2024
Closed
@felixfontein felixfontein requested review from a team and removed request for a team February 20, 2025 20:13
sabre1041
sabre1041 requested changes Mar 1, 2025
View reviewed changes
Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works as described. A few minor items in the README

felixfontein and others added 3 commits March 2, 2025 07:43
@felixfontein @sabre1041
Fix typo.
ac6c53a 
Co-authored-by: Andrew Block <[email protected]>
Signed-off-by: Felix Fontein <[email protected]>
@felixfontein
Small refactor; fix description.
51236ff 
Signed-off-by: Felix Fontein <[email protected]>
@felixfontein
Improve documentation.
c67caf0 
Signed-off-by: Felix Fontein <[email protected]>
sabre1041
sabre1041 approved these changes Mar 2, 2025
View reviewed changes
Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein merged commit f5f5967 into getsops:main Mar 2, 2025
17 checks passed
@felixfontein felixfontein deleted the stdin branch March 2, 2025 20:59
@felixfontein
Copy link
Contributor Author

@sabre1041 thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabre1041 sabre1041 sabre1041 approved these changes

Assignees
No one assigned
Labels
area/CLI enhancement
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.

Piping using /dev/stdin doesn't work on Windows
2 participants
@felixfontein @sabre1041