feat(job-runner): enable snuba jobs command to run from JSON manifest #6320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
xurui-c
force-pushed
the
rachel/manifest
branch
from
5253427
to
b6a2ccc
Compare
onewland
approved these changes
Sep 18, 2024
onkar
approved these changes
Sep 18, 2024
snuba/cli/jobs.py
Outdated
Comment on lines
34
to
38
| params = {} | ||
| for pair in pairs: | ||
| k, v = pair.split("=") | ||
| kwargs[k] = v | ||
| params[k] = v | ||
| return params |
There was a problem hiding this comment.
nit: We can use dict comprehension here. Something like this:
return {k: v for k, v in (pair.split("=") for pair in pairs)}
snuba/manual_jobs/job_loader.py
Outdated
Comment on lines
10
to
12
| if job_type_class is None: | ||
| raise Exception( | ||
| f"Job does not exist. Did you make a file {class_name}.py yet?" | ||
| f"Job does not exist. Did you make a file {job_spec.job_type}.py yet?" |
There was a problem hiding this comment.
Does it make sense to create a custom exception instead of the base Exception?
snuba/manual_jobs/toy_job.py
Outdated
| import click | ||
|
|
||
| from snuba.manual_jobs import Job | ||
| from snuba.cli import logger |
There was a problem hiding this comment.
nit: Not a big deal at this point but do you think we should have a separate logger for manual_jobs? The second answer to this question might be something we want to have, or we can follow the pattern from other modules.
xurui-c
force-pushed
the
rachel/manifest
branch
from
b6a2ccc
to
09b3d13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://getsentry.atlassian.net/browse/SNS-2872
#6288