Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replays): Add _tags_hash_map column definitions #6309

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

cmanallen
Copy link
Member

@cmanallen cmanallen commented Sep 16, 2024

Exposes _tags_hash_map column. Follow the prior art established by the errors table.

Related issue: getsentry/sentry#76289
Migration PR: #6308

@cmanallen cmanallen marked this pull request as ready for review September 16, 2024 17:39
@cmanallen cmanallen requested review from a team as code owners September 16, 2024 17:39
Copy link

codecov bot commented Sep 16, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
1246 1 1245 2
View the top 1 failed tests by shortest run time
tests.migrations.test_runner test_no_schema_differences
Stack Traces | 7.61s run time
Traceback (most recent call last):
  File ".../tests/migrations/test_runner.py", line 478, in test_no_schema_differences
    assert (
AssertionError: Schema mismatch: replays_local does not match schema
assert ["Column '_tags_hash_map' exists in schema but not local ClickHouse!"] == []
  Left contains one more item: "Column '_tags_hash_map' exists in schema but not local ClickHouse!"
  Full diff:
  - []
  + ["Column '_tags_hash_map' exists in schema but not local ClickHouse!"]

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@cmanallen cmanallen merged commit f2199a5 into master Sep 19, 2024
30 checks passed
@cmanallen cmanallen deleted the cmanallen/replays-defined-index-tags-column branch September 19, 2024 19:26
cmanallen added a commit to getsentry/sentry that referenced this pull request Sep 20, 2024
Tags search is expensive from a bytes and rows scanned perspective. This
optimization makes it so that single tag searches can be run quickly and
efficiently.

Depends on: getsentry/snuba#6308 and
getsentry/snuba#6309
Related: #76289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants