feat(eap): Shard meta tables by trace ID #6286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to be able to write queries like this one:
The eap_spans_dist table is sharded by this same shard key
cityHash64(reinterpretAsUInt128(trace_id))
If you don't shard both with the same shard key, you either have to do a two step process (GLOBAL):
this is slow.
Or, you can do
This is incorrect, since you might skip spans which match the conditions, but just happen not to have the meta table rows stored on the same shard.
If you shard both tables by trace_id, you can join on trace_id in a distributed manner, which appears to be ~5x faster.