fix(stories): improve loading/error layout #95171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
JonasBa
approved these changes
Jul 10, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #95171 +/- ##
==========================================
- Coverage 86.68% 84.24% -2.44%
==========================================
Files 10463 10463
Lines 605077 605077
Branches 23637 23637
==========================================
- Hits 524490 509766 -14724
- Misses 80227 94951 +14724
Partials 360 360 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jul 14, 2025
Adjust stories layout when in a loading/error state. **Before** No screenshots, but the spinner and error were crammed in the lower right corner of the page **After** <img width="1944" alt="layout-loading" src="https://github.com/user-attachments/assets/db902b59-ce85-48b1-ada5-f435b49c0c3f" /> <img width="1943" alt="layout-error" src="https://github.com/user-attachments/assets/97e9c9ef-8571-4f63-9fe7-1f745739507e" />
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust stories layout when in a loading/error state.
Before
No screenshots, but the spinner and error were crammed in the lower right corner of the page
After
