fix(grouping): Schedule seer deletion tasks with less hashes #95156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Jul 9, 2025
| for i in range(last_deleted_index, len_hashes, BATCH_SIZE): | ||
| # Slice operations are safe and will not raise IndexError | ||
| chunked_hashes = hashes[i : i + BATCH_SIZE] | ||
| delete_seer_grouping_records_by_hash.apply_async(args=[project_id, chunked_hashes, 0]) |
There was a problem hiding this comment.
Newer tasks will be scheduled with last_deleted_index=0 since we're scheduling a chunked task.
JoshFerge
reviewed
Jul 9, 2025
| # Iterate through hashes in chunks and schedule a task for each chunk | ||
| # There are tasks passing last_deleted_index, thus, we need to start from that index | ||
| # Eventually all tasks will pass 0 | ||
| for i in range(last_deleted_index, len_hashes, BATCH_SIZE): |
There was a problem hiding this comment.
do we want to add similar tests to make sure the right number of tasks get called?
There was a problem hiding this comment.
I think this test I added yesterday covers it.
JoshFerge
approved these changes
Jul 9, 2025
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #95156 +/- ##
==========================================
+ Coverage 87.84% 87.90% +0.05%
==========================================
Files 10469 10459 -10
Lines 605374 604694 -680
Branches 23674 23571 -103
==========================================
- Hits 531819 531575 -244
+ Misses 73195 72758 -437
- Partials 360 361 +1 |
markstory
approved these changes
Jul 9, 2025
| end_index = min(last_deleted_index + BATCH_SIZE, len_hashes) | ||
| call_seer_to_delete_these_hashes(project_id, hashes[last_deleted_index:end_index]) | ||
| if end_index < len_hashes: | ||
| delete_seer_grouping_records_by_hash.apply_async(args=[project_id, hashes, end_index]) |
There was a problem hiding this comment.
Is this where all the continued stream of big tasks was coming from?
There was a problem hiding this comment.
@markstory yes, this is where it came from
armenzg
force-pushed
the
fix/split_seer_deletions/armenzg
branch
from
0161fd9 to
97e7fba
Compare
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
armenzg
added a commit
that referenced
this pull request
Jul 11, 2025
This simplifies the tests for deletions of hashes from Seer and it also adds a test for #95156.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jul 14, 2025
The original code would always pass all hashes to all tasks spawned, thus, we could end up with massive payloads for tasks causing trouble to taskbroker. We got into such a situation in the last few days when the deletion of a project would lead to hundreds of thousands of hashes being passed to tasks (179k+ hashes -> 6MB+ task payloads). The changes here would take all hashes from a task, chunk the hashes and spawn new tasks with a small size of hashes. This moves us from sequential scheduling of tasks to parallelized scheduling. This could have an impact on the Seer service if a massive number of hashes are requested for deletion. Ref inc-1236
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jul 14, 2025
This simplifies the tests for deletions of hashes from Seer and it also adds a test for #95156.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues: Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code would always pass all hashes to all tasks spawned, thus, we could end up with massive payloads for tasks causing trouble to taskbroker.
We got into such a situation in the last few days when the deletion of a project would lead to hundreds of thousands of hashes being passed to tasks (179k+ hashes -> 6MB+ task payloads).
The changes here would take all hashes from a task, chunk the hashes and spawn new tasks with a small size of hashes.
This moves us from sequential scheduling of tasks to parallelized scheduling.
This could have an impact on the Seer service.
Ref inc-1236