Skip to content

Migrate sampling_context to use SDK 3.0 attributes #94022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jun 23, 2025

See the Celery and WSGI sections in the migration guide

Closes getsentry/sentry-python#4505

@sentrivana sentrivana requested a review from a team as a code owner June 23, 2025 10:10
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 23, 2025
Copy link

codecov bot commented Jun 23, 2025

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
26581 3 26578 231
View the top 3 failed test(s) by shortest run time
tests.relay_integration.test_sdk::test_encoding[MONOLITH]
Stack Traces | 105s run time
#x1B[1m#x1B[31mtests/relay_integration/test_sdk.py#x1B[0m:98: in test_encoding
    assert event.data["project"] == settings.SENTRY_PROJECT
#x1B[1m#x1B[31mE   AttributeError: 'NoneType' object has no attribute 'data'#x1B[0m
tests.relay_integration.test_sdk::test_recursion_breaker[MONOLITH]
Stack Traces | 118s run time
#x1B[1m#x1B[31mtests/relay_integration/test_sdk.py#x1B[0m:81: in test_recursion_breaker
    with pytest.raises(Exception):
#x1B[1m#x1B[31mE   Failed: DID NOT RAISE <class 'Exception'>#x1B[0m
tests.relay_integration.test_sdk::test_simple[MONOLITH]
Stack Traces | 118s run time
#x1B[1m#x1B[31mtests/relay_integration/test_sdk.py#x1B[0m:64: in test_simple
    assert event
#x1B[1m#x1B[31mE   assert None#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@sentrivana sentrivana merged commit 25712df into antonpirker/code-changes-for-sdk-3.0.0 Jun 23, 2025
57 of 62 checks passed
@sentrivana sentrivana deleted the ivana/3.0/sampling-context-changes branch June 23, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants