Skip to content

ref(github): Open PR Comment Workflow #90717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jianyuan
Copy link
Contributor

@jianyuan jianyuan commented May 1, 2025

Make the Open PR Comment Workflow generic. Migrate the GitHub integration to utilize it.

@jianyuan jianyuan requested review from a team as code owners May 1, 2025 00:13
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 1, 2025
@iamrajjoshi iamrajjoshi added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label May 1, 2025
Copy link
Member

@cathteng cathteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable

@cathteng cathteng enabled auto-merge (squash) May 1, 2025 18:14
@github-actions github-actions bot removed the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label May 1, 2025
@iamrajjoshi iamrajjoshi added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label May 1, 2025
@cathteng cathteng merged commit 9c322b2 into getsentry:master May 1, 2025
59 of 60 checks passed
Copy link

sentry-io bot commented May 1, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ NotImplementedError sentry.integrations.github.tasks.open_pr_commen... View Issue

Did you find this useful? React with a 👍 or 👎

@Zylphrex Zylphrex added the Trigger: Revert Add to a merged PR to revert it (skips CI) label May 1, 2025
@getsentry-bot
Copy link
Contributor

PR reverted: 5c36d24

getsentry-bot added a commit that referenced this pull request May 1, 2025
@Zylphrex
Copy link
Member

Zylphrex commented May 1, 2025

Reverting to unblock as this is crashing in prod with the NotImplementedError

@jianyuan
Copy link
Contributor Author

jianyuan commented May 1, 2025

@Zylphrex Thanks for reporting this. I believe it’s due to the GitHub Enterprise webhook (incorrectly?) using the GitHub integrations in the existing codebase. I’ll create a stub GitHub Enterprise integration and reintroduce the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants