Skip to content

feat(github): Support Github multi org in Github installation pipeline #90709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Christinarlong
Copy link
Contributor

@Christinarlong Christinarlong commented Apr 30, 2025

Depends on #90342

This PR

  1. Gets a user's installations from GitHub, filters through which one's the user is an owner of
  2. Adds a new PipelineView
    • Returns a the UI page when the user has an existing installation they can choose
    • If there is no eligible existing installations, go to the next view (GithubInstallation)
  3. In the GithubInstallation view, check if an existing installation was chosen if so, move to the next step (_finish_pipeline)

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 30, 2025
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #90709       +/-   ##
===========================================
+ Coverage   53.25%   87.80%   +34.55%     
===========================================
  Files       10271    10279        +8     
  Lines      582624   583513      +889     
  Branches    22569    22566        -3     
===========================================
+ Hits       310291   512381   +202090     
+ Misses     271904    70703   -201201     
  Partials      429      429               

@Christinarlong Christinarlong marked this pull request as ready for review May 1, 2025 16:56
@Christinarlong Christinarlong requested review from a team as code owners May 1, 2025 16:56
Copy link
Member

@cathteng cathteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we make sure all changes are feature flagged? currently this will enable multi org as soon as it's merged.

@Christinarlong Christinarlong marked this pull request as draft May 1, 2025 17:09
@Christinarlong Christinarlong marked this pull request as ready for review May 1, 2025 18:51
@Christinarlong Christinarlong requested a review from cathteng May 1, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants