fix(taskworker) Update cluster_projects so it can not use pickle #90705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we invoke this task with a list of `Project` models that are pickled. This has escaped our existing pickle detection logic as all calls to the task are mocked. This set of changes introduces a new `project_ids` parameter that will let us not need pickle. Once this has deployed, I'll change the callsites to pass `project_ids` and deprecate `projects` usage. Refs #90681
github-actions
bot
added
the
Scope: Backend
evanh
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we invoke this task with a list of
Projectmodels that are pickled. This has escaped our existing pickle detection logic as all calls to the task are mocked.This set of changes introduces a new
project_idsparameter that will let us not need pickle. Once this has deployed, I'll change the callsites to passproject_idsand deprecateprojectsusage.Refs #90681