feat(replay): add hovercard to release tag and filter dropdown #90701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
michellewzhang
changed the title
|
@michellewzhang just to clarify, what happens when you click on the release version now, is it still linking to search w/ release? |
nothing happens when you click -- you have to click the 3 dots to see the 2 options |
billyvg
approved these changes
May 1, 2025
| @@ -25,6 +29,8 @@ const expandedViewKeys = [ | |||
| 'sdk.replay.maskingRules', | |||
| ]; | |||
|
|
|||
| const releaseKeys = ['release', 'releases']; | |||
| label: t('Go to release details'), | ||
| onAction: () => | ||
| navigate( | ||
| makeReleasesPathname({ |
There was a problem hiding this comment.
Note for myself, I'll have to update these calls when #90428 lands
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #90701 +/- ##
==========================================
- Coverage 87.84% 84.25% -3.60%
==========================================
Files 10265 10265
Lines 580837 580835 -2
Branches 22569 22568 -1
==========================================
- Hits 510235 489366 -20869
- Misses 70169 91036 +20867
Partials 433 433 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 12, 2025
closes #90633 - adds a release hovercard to the `release` tag in replay details - previous behavior was that if the tag was clicked, it would populate the replay search bar with the `release:xxx` filter - new behavior is a dropdown that has 2 options: same search behavior as before, or going to release details - also removes deprecated `browserHistory` from the replay index table cell dropdown filters https://github.com/user-attachments/assets/6d5a0fa8-aea2-4c72-989d-84a31ba8e05b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #90633
releasetag in replay detailsrelease:xxxfilterbrowserHistoryfrom the replay index table cell dropdown filtersScreen.Recording.2025-04-30.at.1.39.33.PM.mov