-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(replay): add hovercard to release tag and filter dropdown #90701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@michellewzhang just to clarify, what happens when you click on the release version now, is it still linking to search w/ release? |
nothing happens when you click -- you have to click the 3 dots to see the 2 options |
@@ -25,6 +29,8 @@ const expandedViewKeys = [ | |||
'sdk.replay.maskingRules', | |||
]; | |||
|
|||
const releaseKeys = ['release', 'releases']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l: this could be a Set
label: t('Go to release details'), | ||
onAction: () => | ||
navigate( | ||
makeReleasesPathname({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for myself, I'll have to update these calls when #90428 lands
closes #90633
release
tag in replay detailsrelease:xxx
filterbrowserHistory
from the replay index table cell dropdown filtersScreen.Recording.2025-04-30.at.1.39.33.PM.mov