Skip to content

feat(replay): add hovercard to release tag and filter dropdown #90701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michellewzhang
Copy link
Member

@michellewzhang michellewzhang commented Apr 30, 2025

closes #90633

  • adds a release hovercard to the release tag in replay details
  • previous behavior was that if the tag was clicked, it would populate the replay search bar with the release:xxx filter
  • new behavior is a dropdown that has 2 options: same search behavior as before, or going to release details
  • also removes deprecated browserHistory from the replay index table cell dropdown filters
Screen.Recording.2025-04-30.at.1.39.33.PM.mov

@michellewzhang michellewzhang requested a review from a team as a code owner April 30, 2025 20:46
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 30, 2025
@michellewzhang michellewzhang changed the title ref(replay): add hovercard to release tag and filter dropdown feat(replay): add hovercard to release tag and filter dropdown May 1, 2025
@billyvg
Copy link
Member

billyvg commented May 1, 2025

@michellewzhang just to clarify, what happens when you click on the release version now, is it still linking to search w/ release?

@michellewzhang
Copy link
Member Author

@michellewzhang just to clarify, what happens when you click on the release version now, is it still linking to search w/ release?

nothing happens when you click -- you have to click the 3 dots to see the 2 options

@@ -25,6 +29,8 @@ const expandedViewKeys = [
'sdk.replay.maskingRules',
];

const releaseKeys = ['release', 'releases'];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: this could be a Set

label: t('Go to release details'),
onAction: () =>
navigate(
makeReleasesPathname({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for myself, I'll have to update these calls when #90428 lands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Replay] Add release context on hover, and link to fly out
2 participants