feat(grouping): Add feature flag and sample rate for split enhancements #90679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## kmclb-add-ability-to-use-split-enhancement-rules #90679 +/- ##
====================================================================================
+ Coverage 87.55% 87.85% +0.30%
====================================================================================
Files 10261 10261
Lines 580801 580814 +13
Branches 22561 22561
====================================================================================
+ Hits 508496 510261 +1765
+ Misses 71872 70120 -1752
Partials 433 433 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds both a feature flag (
organizations:run-split-enhancements) and a sample rate option (grouping.split_enhancements.sample_rate) to control the running of split enhancements. It also adds a helper,get_enhancements_version, which uses the two to determine if the enhancements created should be version 2 (the current version, with no split enhancements) or version 3 (the new version, which does have them). Finally, it calls the helper when loading enhancements from project options, so that once orgs are opted in and the sample rate is set to something other than 0, the experiment will be enabled.