Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spike(sentry apps): Spike out what context manager usage will look for ext. requests #85880

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Christinarlong
Copy link
Contributor

Using SelectRequester as the example here:

Context: SelectRequester is one our most used dataclasses as it queries the 3p integrator to get the 'options' they want us to display for the 'Select' input/dropdown field. Here we're just wrapping the .run()/driver function in the context manager. We add halts for the failures as the errors are usually from the 3p giving us a bad URL or incorrect format.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
23718 1 23717 292
View the top 1 failed test(s) by shortest run time
tests.sentry.sentry_apps.external_requests.test_select_requester.TestSelectRequester::test_invalid_response_missing_value
Stack Traces | 4.49s run time
#x1B[1m#x1B[.../sentry_apps/external_requests/test_select_requester.py#x1B[0m:114: in test_invalid_response_missing_value
    ).run()
#x1B[1m#x1B[.../sentry_apps/external_requests/select_requester.py#x1B[0m:119: in run
    return formatted_response
#x1B[1m#x1B[31mE   UnboundLocalError: cannot access local variable 'formatted_response' where it is not associated with a value#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant