Repository navigation
fix(seer): Run SCM-stream PR iteration as the org's integration - #128961
Merged
Merged
Conversation
GitHub webhooks are anonymous, so after #128931 the SCM stream listeners dispatch PR-iteration tasks with no viewer context and every Seer call raises MissingViewerContextError (#126918). Fixes SENTRY-5ZE4
github-actions
Bot
added
the
Scope: Backend
gricha
marked this pull request as ready for review
October 27, 2026 22:05
trevor-e
approved these changes
Oct 27, 2026
gricha
added a commit
that referenced
this pull request
Oct 28, 2026
Reverts #128931 (back to sentry-viewercontext 0.2.0 and the `UNKNOWN` actor for anonymous requests). Rolling it out leaves regions half-deployed: old pods send `"unknown"` that new pods can't read, and new pods send no context where old pods expect one. That is failing Autofix PR iteration (SENTRY-5ZE4) in US, which is paused mid-canary, and flooding SENTRY-5Z86. Keeps #128961 and #128970. The only conflict was the RPC test #128970 added for an unparseable `unknown` actor, which no longer applies on 0.2.0. Seer half: getsentry/seer#9159.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs the GitHub PR-iteration work on the SCM stream under
webhook_viewer_context(org)(INTEGRATION + org), the same context the legacy GitHub webhook handlers set.GitHub webhooks are anonymous. Until #128931 the middleware gave them an
UNKNOWNviewer context, which rode the task headers intoprocess_pr_iteration_check_suiteandtrigger_pr_iteration_from_reviewand satisfied the ambient-context check from #126918. WithUNKNOWNgone those tasks have no context, so every Seer call raisesMissingViewerContextError(SENTRY-5ZE4, s4s2 only so far; DE/US get it on their next deploy).listeners/check_suite.pyis mostly re-indentation; review with whitespace hidden.Comment and pause tasks were already covered, because the legacy GitHub webhook dispatches them inside
webhook_viewer_context.Fixes SENTRY-5ZE4