Skip to content

ref(np): Remove unused stage from notification tracking - #128727

Merged
hobzcalvin merged 1 commit into
masterfrom
grantpatterson/remove-notification-tracking-stage
Oct 26, 2026
Merged

hobzcalvin merged 1 commit into
masterfrom
grantpatterson/remove-notification-tracking-stage

Conversation

@hobzcalvin

Copy link
Copy Markdown
Contributor

Nothing sets stage, and a notification's source already identifies what was sent, so drop it from the tracking context, metric tags, and analytics events.

This was basically me not noticing the agent adding this in, and now I realize we don't want to do something special just for Seer Autofix (which renders separate "stages" from a single template). So we'll just track all autofix links as a singe source, which I think is fine, at least until we know we want more granularity.

Nothing sets stage, and a notification's source already identifies what was sent, so drop it from the tracking context, metric tags, and analytics events.
@hobzcalvin
hobzcalvin requested review from a team as code owners October 23, 2026 23:53
@hobzcalvin
hobzcalvin requested a review from shayna-ch October 23, 2026 23:53
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 23, 2026
@hobzcalvin
hobzcalvin merged commit 2eac2cf into master Oct 26, 2026
65 of 70 checks passed
@hobzcalvin
hobzcalvin deleted the grantpatterson/remove-notification-tracking-stage branch October 26, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants