Repository navigation
feat(aci): Explain incident markers in metric monitor chart tooltips - #128695
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
RudraPatel2003
marked this pull request as ready for review
October 23, 2026 21:00
Member
Author
|
bugbot review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit bfff7d6. Configure here.
RudraPatel2003
force-pushed
the
rudra-chart-tooltips
branch
from
October 23, 2026 21:28
bfff7d6 to
9467e66
Compare
RudraPatel2003
force-pushed
the
rudra-chart-tooltips
branch
from
October 23, 2026 22:27
9467e66 to
29761d4
Compare
Contributor
Sentry Snapshot Testing
|
RudraPatel2003
force-pushed
the
rudra-chart-tooltips
branch
from
October 23, 2026 22:33
29761d4 to
7e089cf
Compare
RudraPatel2003
force-pushed
the
rudra-chart-tooltips
branch
from
October 23, 2026 23:01
7e089cf to
7b0d4d3
Compare
RudraPatel2003
force-pushed
the
rudra-chart-tooltips
branch
from
October 26, 2026 16:57
7b0d4d3 to
a019640
Compare
cvxluo
approved these changes
Oct 26, 2026
cvxluo
left a comment
cvxluo
left a comment
Contributor
There was a problem hiding this comment.
nice quite happy with the solution you landed on
RudraPatel2003
force-pushed
the
rudra-chart-tooltips
branch
from
October 26, 2026 23:37
a019640 to
63e2b5a
Compare
The open period marker, start line, and value tooltips name the issue by its short ID instead of the open period number. The striped trigger interval gets its own tooltip showing the interval that breached the threshold.
RudraPatel2003
force-pushed
the
rudra-chart-tooltips
branch
from
October 26, 2026 23:47
63e2b5a to
d0df65e
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves ID-1952
Dashed section
Before
After
Solid section
Before
After
Vertical Line
Before
After
