Repository navigation
feat(aci): Fix overlapping highlight bands on metric detector chart - #128689
RudraPatel2003 wants to merge 8 commits into
Conversation
RudraPatel2003
changed the title
github-actions
Bot
added
the
Scope: Frontend
Sentry Snapshot Testing
|
|
bugbot review |
cd0df4c to
9ce0f67
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f33c684. Configure here.
| const percentThresholdBands = createPercentThresholdBandSeries({ | ||
| theme, | ||
| thresholds: thresholdLines.map(line => ({...line, bound: line.series.data})), | ||
| }); |
There was a problem hiding this comment.
Percent bands ignore custom resolution
Low Severity
createPercentThresholdBandSeries is called without resolution, so a custom percent resolve threshold never becomes the OK bound. The green band then extends to the least-severe alert line and paints the unresolved hysteresis zone as healthy.
Reviewed by Cursor Bugbot for commit f33c684. Configure here.
There was a problem hiding this comment.
This is true; fixing it
There was a problem hiding this comment.
Prod doesn't draw a green line either actually. In this monitor red is 100% yellow is 50% and green is 25%
Production:
My change:
I also ordered the tooltips
Prod:
My change:
Resolves ID-1951
Now we calculate how we partition the graph
Before:
After:
