feat(np): migrate legacy issue alerts to np by shayna-ch · Pull Request #127289 · getsentry/sentry

shayna-ch · 2026-10-13T18:31:16Z

migrates legacy issue alerts to np for teams, slack, and discord.

Shared send logic: metric and issue alerts now share the code that builds the send target, decides whether to thread, and sends with failure logging.
Threading: follow-up alerts for the same issue reply in the original Slack thread and are also posted to the channel, matching legacy. Uptime and metric issues get a new thread for each open period.
Activity updates: resolve, assign, archive and similar updates are now also posted in Slack threads created by the platform. For uptime issues they go only to the current open period's thread.
Seer autofix: Slack threads from platform alerts are registered for Seer autofix updates, always using the thread's root message.

shayna-ch · 2026-10-19T18:43:12Z

bugbot run

cursor

Stale Bugbot comment from a previous run.

shayna-ch · 2026-10-19T18:56:48Z

bugbot run

cursor

Stale Bugbot comment from a previous run.

shayna-ch · 2026-10-19T19:34:52Z

bugbot run

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 2aff789. Configure here.}

hobzcalvin

I'm not too familiar with the existing threading behavior, so some of these questions may not make sense. 😆

hobzcalvin · 2026-10-22T22:47:57Z

+ThreadOptionKey = Literal[
+    "sentry:issue_alerts_thread_flag",
+    "sentry:metric_alerts_thread_flag",
+]


I was thinking this could live somewhere tied to OrganizationOption? Like I actually don't need a type just for this one specific file/use-case (kinda consider it overkill), but I was more surprised the OrganizationOption stuff didn't have anything to enforce the sorts of strings that go in there.

agreed, switched it back to how it was originally. Tying it to OrganizationOption seems like it would be a bigger change, so I made a follow up ticket ISWF-3631, i dont think its quite urgent enough to postpone the rollout more

hobzcalvin

thanks for all the back and forth; looking good! I think there are few lingering comments to resolve, otherwise good to ship.

sentry · 2026-10-26T15:22:02Z

Sentry Snapshot Testing

Name	Added	Removed	Changed	Renamed	Unchanged	Skipped	Status
sentry-frontend `sentry-frontend`	0	0	0	0	760	0	✅ Unchanged

⚙️ sentry-frontend Snapshot Settings

Co-Authored-By: Shayna Chambless <shayna.chambless@sentry.io>

…_with_response The method is also used for non-threaded sends because it's the one that returns the provider response (e.g. Slack's message ts). Name it for that. Co-Authored-By: Shayna Chambless <shayna.chambless@sentry.io>

Thread creators set ThreadKey.object_id (the group ID for issue and metric alert threads) and it's saved on new threads. The issue activity path now finds every platform thread for an issue by (key_type, object_id) instead of searching key_data. Co-Authored-By: Shayna Chambless <shayna.chambless@sentry.io>

…ype and object_id Platform threads now record the kind of object they're about alongside object_id, and activity replies find issue threads by (object_type, object_id), which the new index covers. Co-Authored-By: Shayna Chambless <shayna.chambless@sentry.io>

Drop the file-specific ThreadOptionKey Literal; OrganizationOption keys are plain strings everywhere else. Shared key typing is tracked separately. Co-Authored-By: Shayna Chambless <shayna.chambless@sentry.io>

github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 13, 2026

shayna-ch changed the base branch from master to shayna-ch/connect-legacy-new-renderer October 13, 2026 18:33

shayna-ch added this pull request to stack #127290 October 13, 2026 18:33

shayna-ch changed the title ~~connect legacy alert ot new renderer~~ issue alerts Oct 13, 2026

shayna-ch force-pushed the shayna-ch/np-legacy-issue-alerts branch from 8adb8dc to 2fa4031 Compare October 13, 2026 18:36

Base automatically changed from shayna-ch/connect-legacy-new-renderer to master October 15, 2026 16:53

shayna-ch force-pushed the shayna-ch/np-legacy-issue-alerts branch 2 times, most recently from da00165 to ef77a1e Compare October 19, 2026 16:09

sentry-warden Bot reviewed Oct 19, 2026

View reviewed changes

Comment thread src/sentry/integrations/slack/service.py Outdated

Comment thread src/sentry/notifications/notification_action/platform_dispatch.py Outdated

shayna-ch changed the title ~~issue alerts~~ feat(np): migrate legacy issue alerts to np Oct 19, 2026

cursor Bot reviewed Oct 19, 2026

View reviewed changes

Comment thread src/sentry/notifications/notification_action/platform_dispatch.py

cursor Bot reviewed Oct 19, 2026

View reviewed changes

Comment thread src/sentry/integrations/slack/service.py

sentry-warden Bot reviewed Oct 19, 2026

View reviewed changes

Comment thread src/sentry/integrations/slack/service.py

cursor Bot reviewed Oct 19, 2026

View reviewed changes

shayna-ch commented Oct 19, 2026

View reviewed changes

Comment thread src/sentry/notifications/notification_action/platform_dispatch.py

shayna-ch marked this pull request as ready for review October 19, 2026 20:07

shayna-ch requested review from a team as code owners October 19, 2026 20:07

shayna-ch requested a review from hobzcalvin October 19, 2026 20:07

hobzcalvin reviewed Oct 21, 2026

View reviewed changes

shayna-ch requested a review from hobzcalvin October 21, 2026 21:18

hobzcalvin reviewed Oct 22, 2026

View reviewed changes

hobzcalvin approved these changes Oct 23, 2026

View reviewed changes

shayna-ch marked this pull request as draft October 23, 2026 21:18

vercel Bot deployed to Preview October 23, 2026 21:26

View deployment

shayna-ch marked this pull request as ready for review October 23, 2026 21:30

sentry-junior Bot force-pushed the shayna-ch/np-legacy-issue-alerts branch from cd3ac3b to f6e1b38 Compare October 26, 2026 15:19

shayna-ch and others added 13 commits October 26, 2026 16:20

issue alerts

3f34ca3

Co-Authored-By: Shayna Chambless <shayna.chambless@sentry.io>

tests

0fe7969

Co-Authored-By: Shayna Chambless <shayna.chambless@sentry.io>

fixes

cd3851b

Co-Authored-By: Shayna Chambless <shayna.chambless@sentry.io>

fixes

e0e8e0a

Co-Authored-By: Shayna Chambless <shayna.chambless@sentry.io>

threads

f5cb5ee

Co-Authored-By: Shayna Chambless <shayna.chambless@sentry.io>

bugbot

121e817

Co-Authored-By: Shayna Chambless <shayna.chambless@sentry.io>

warden

572ae5e

Co-Authored-By: Shayna Chambless <shayna.chambless@sentry.io>

ref(np): Restrict _should_thread key to threading option keys

663edd1

Co-Authored-By: Shayna Chambless <shayna.chambless@sentry.io>

ref(slack): Drop redundant is not None on rollout tier check

350e97e

Co-Authored-By: Shayna Chambless <shayna.chambless@sentry.io>

ref(notifications): Type thread option key as str

986dc7a

Drop the file-specific ThreadOptionKey Literal; OrganizationOption keys are plain strings everywhere else. Shared key typing is tracked separately. Co-Authored-By: Shayna Chambless <shayna.chambless@sentry.io>

sentry-junior Bot force-pushed the shayna-ch/np-legacy-issue-alerts branch from f6e1b38 to 986dc7a Compare October 26, 2026 16:21

shayna-ch merged commit 732ca5b into master Oct 26, 2026
81 checks passed

shayna-ch deleted the shayna-ch/np-legacy-issue-alerts branch October 26, 2026 16:34

This was referenced Oct 26, 2026

feat(notifications): Store the integration on NotificationThread #128764

Open

feat(slack): Send investigation conclusions to every metric alert thread #128771

Open

Conversation

shayna-ch commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shayna-ch commented Oct 19, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shayna-ch commented Oct 19, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shayna-ch commented Oct 19, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hobzcalvin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hobzcalvin Oct 22, 2026

Choose a reason for hiding this comment

Uh oh!

shayna-ch Oct 23, 2026

Choose a reason for hiding this comment

Uh oh!

hobzcalvin left a comment

Choose a reason for hiding this comment

Uh oh!

sentry Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Sentry Snapshot Testing

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shayna-ch commented Oct 13, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading

sentry Bot commented Oct 26, 2026 •

edited

Loading