Skip to content

perf(api): Use lightweight contexts across control permissions - #124850

Draft
shashjar wants to merge 6 commits into
shashjar/iswf-3361-lightweight-accessfrom
shashjar/iswf-3361-control-context-defaults
Draft

shashjar wants to merge 6 commits into
shashjar/iswf-3361-lightweight-accessfrom
shashjar/iswf-3361-control-context-defaults

Conversation

@shashjar

@shashjar shashjar commented Sep 17, 2026 •

Copy link
Copy Markdown
Member

Refs https://linear.app/getsentry/issue/ISWF-3361/determine-access-hydrates-every-project-and-team-on-31percent-of-all.

Control organization endpoints now use the dedicated access context, removing eager project/team hydration and collection opt-in flags. Migrate remaining Sentry App, organization-user, and user-integration lookups that need only access metadata. Privileged integration requests now receive the correct resource IDs instead of empty collections.

Service-account create/update validation checks only submitted, accessible IDs against active projects in the organization. Cap requests at 1,000 entries and deduplicate before the RPC; GET, empty grants, and feature-disabled requests skip validation.

@linear-code

linear-code Bot commented Sep 17, 2026

Copy link
Copy Markdown

ISWF-3361

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 17, 2026
@shashjar
shashjar force-pushed the shashjar/iswf-3361-control-context-defaults branch from 1d43a7a to cece4a6 Compare September 17, 2026 22:23
@shashjar
shashjar force-pushed the shashjar/iswf-3361-control-context-defaults branch from cece4a6 to 7789122 Compare September 17, 2026 23:02
@shashjar
shashjar added this pull request to stack #125109 September 21, 2026 19:50
@getsantry

getsantry Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry Bot added the Stale label Oct 15, 2026
@shashjar

Copy link
Copy Markdown
Member Author

WIP

@shashjar shashjar removed the Stale label Oct 15, 2026
@shashjar
shashjar force-pushed the shashjar/iswf-3361-control-context-defaults branch from 7789122 to 68a43d3 Compare October 21, 2026 21:25
@sentry

sentry Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Sentry Snapshot Testing

Name Added Removed Changed Renamed Unchanged Skipped Status
sentry-frontend
sentry-frontend
0 0 0 0 760 0 ✅ Unchanged

⚙️ sentry-frontend Snapshot Settings

Default control organization endpoints to lightweight RPC contexts with explicit resource opt-ins.
Validate service-account grants using active project IDs and inherit the new integration defaults.

Refs ISWF-3361
@shashjar
shashjar force-pushed the shashjar/iswf-3361-control-context-defaults branch from 68a43d3 to 4c385d8 Compare October 21, 2026 22:11
@shashjar
shashjar marked this pull request as ready for review October 21, 2026 22:16
@shashjar
shashjar requested review from a team as code owners October 21, 2026 22:17
@shashjar
shashjar requested review from a team and removed request for a team October 21, 2026 22:17

@Christinarlong Christinarlong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

claude do we need all these tests

@shashjar
shashjar marked this pull request as draft October 23, 2026 20:04
Use access contexts for control organization endpoints and remaining Sentry App and organization-user callers. Validate only submitted active service-account project IDs, and remove collection hydration flags.

Refs ISWF-3361
@shashjar shashjar changed the title perf(api): Omit full resources from control organization contexts perf(api): Use lightweight contexts across control permissions Oct 23, 2026
Carry the provider simplification through the stack and keep the no-hydration guard on the helper.

Refs ISWF-3361
Adapt lightweight access to persisted service accounts, bound submitted grants, and migrate the remaining user integration lookup.

Refs ISWF-3361

This branch was successfully deployed

1 active (outdated) deployment
Preview — cc7980ef Deployed Oct 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants