Skip to content

chore(billing): added trace metrics to byte categories(BIL-2221) #112279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krithikravi merged 1 commit into from
Apr 6, 2026
Merged

chore(billing): added trace metrics to byte categories(BIL-2221) #112279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion static/gsApp/utils/dataCategory.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,9 +416,10 @@ describe('listDisplayNames', () => {
});

describe('isByteCategory', () => {
it('verifies isByteCategory function handles both ATTACHMENTS and LOG_BYTE', () => {
it('verifies isByteCategory function handles ATTACHMENTS, LOG_BYTE, and TRACE_METRIC_BYTE', () => {
expect(isByteCategory(DataCategory.ATTACHMENTS)).toBe(true);
expect(isByteCategory(DataCategory.LOG_BYTE)).toBe(true);
expect(isByteCategory(DataCategory.TRACE_METRIC_BYTE)).toBe(true);
expect(isByteCategory(DataCategory.ERRORS)).toBe(false);
expect(isByteCategory(DataCategory.TRANSACTIONS)).toBe(false);
});
Expand Down
6 changes: 5 additions & 1 deletion static/gsApp/utils/dataCategory.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,11 @@ export function isContinuousProfiling(category: DataCategory | string) {
}

export function isByteCategory(category: DataCategory | string) {
return category === DataCategory.ATTACHMENTS || category === DataCategory.LOG_BYTE;
return (
category === DataCategory.ATTACHMENTS ||
category === DataCategory.LOG_BYTE ||
category === DataCategory.TRACE_METRIC_BYTE
);
}

/**
Expand Down
Loading