Skip to content

Added device_type to tag mapping #104957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bitsandfoxes merged 3 commits into from
Dec 15, 2025
+9 −1
Merged

Added device_type to tag mapping #104957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71ba138
Added device_type to tag mapping
bitsandfoxes Dec 15, 2025
04a3a7c
Added device_type to tag mapping
bitsandfoxes Dec 15, 2025
c68cc54
Merge branch 'feat/device-type-tag-mapping' of https://github.com/get…
bitsandfoxes Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/sentry/interfaces/contexts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,11 @@ class AppContextType(ContextType):
@contexttype
class DeviceContextType(ContextType):
type = "device"
context_to_tag_mapping = {"": "{model}", "family": "{family}"}
context_to_tag_mapping = {
"": "{model}",
"family": "{family}",
"device_type": "{device_type}",
}
# model_id, arch


Expand Down
3 changes: 3 additions & 0 deletions tests/sentry/event_manager/interfaces/snapshots/test_contexts/test_device.pysnap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,12 @@ errors: null
tags:
- - device
- iPad
- - device.device_type
- Handheld
to_json:
device:
arch: arm64
device_type: Handheld
model: iPad
model_id: 1234AB
name: My iPad
Expand Down
1 change: 1 addition & 0 deletions tests/sentry/event_manager/interfaces/test_contexts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ def test_device(make_ctx_snapshot) -> None:
"model_id": "1234AB",
"version": "1.2.3",
"arch": "arm64",
"device_type": "Handheld",
}
}
)
Expand Down
Loading