fix(explorer): Use correct query mode #101394
Merged
+58
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| fields = list(group_by) | ||
| fields = [] | ||
| if group_by: | ||
| fields.extend(group_by) |
There was a problem hiding this comment.
Bug: Empty Fields List Causes API Failures
In execute_trace_query_table, when mode="aggregates" and both group_by and y_axes are empty, the fields list becomes empty. This can cause API calls to the events endpoint to fail. The previous logic implicitly ensured fields were present by falling back to default span fields, a safeguard removed by the new explicit mode parameter.
JoshFerge
approved these changes
Oct 14, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #101394 +/- ##
===========================================
- Coverage 81.15% 81.04% -0.11%
===========================================
Files 8704 8699 -5
Lines 388023 385840 -2183
Branches 24400 24400
===========================================
- Hits 314888 312697 -2191
- Misses 72784 72792 +8
Partials 351 351 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Receives new query mode param from https://github.com/getsentry/seer/pull/3595 to correctly determine which mode to use. The previous condition was not correct logic in all cases