feat(ui): Stabilize page titles, remove layout props #101379
Open
+47
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when OrganizationLayout rerenders it was causing the document title to reset to "Sentry" sometimes overwriting the better title that was already rendered.
github-actions
bot
added
the
Scope: Frontend
malwilley
reviewed
Oct 10, 2025
| component: errorHandler(OrganizationLayout), | ||
| children: [ | ||
| { | ||
| path: '*', |
There was a problem hiding this comment.
Do you actually need the path key here?
Comment on lines
+3144
to
+3149
| children: [ | ||
| { | ||
| path: '*', | ||
| component: errorHandler(RouteNotFound), | ||
| }, | ||
| ], |
There was a problem hiding this comment.
Suggested change
| children: [ | |
| { | |
| path: '*', | |
| component: errorHandler(RouteNotFound), | |
| }, | |
| ], | |
| children: [{component: errorHandler(RouteNotFound)}], |
evanpurkhiser
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When OrganizationLayout rerenders it was causing the document title to reset to "Sentry" sometimes overwriting the more accurate page title that was already rendered. Remove all rerendering by removing deprecated router props and moving global analytics into its own component