Skip to content

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Sep 12, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Lets link logs with the replay ID.

💡 Motivation and Context

It solves an issue requesting the addition of this feature.

💚 How did you test it?

Testing on an app.

https://sentry-sdks.sentry.io/explore/logs/?end=2025-09-12T12%3A41%3A00&logsFields=timestamp&logsFields=message&logsSortBys=-timestamp&project=5428561&start=2025-09-12T12%3A11%3A00

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

Close #5160

Copy link
Contributor

github-actions bot commented Sep 12, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against ce4cfe7

Copy link
Contributor

github-actions bot commented Sep 12, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 433.74 ms 458.74 ms 25.00 ms
Size 17.75 MiB 19.68 MiB 1.94 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
818a608 495.84 ms 498.08 ms 2.25 ms
8d89cc9+dirty 537.83 ms 536.02 ms -1.81 ms
d916aa3 425.37 ms 427.02 ms 1.65 ms
20d5eaa 377.62 ms 406.50 ms 28.88 ms
1853710 555.47 ms 556.59 ms 1.12 ms
c1573b3 400.85 ms 411.82 ms 10.97 ms
9f211e3 451.50 ms 500.00 ms 48.50 ms
e2fa43d 451.68 ms 462.42 ms 10.74 ms
7be1f99 454.83 ms 461.36 ms 6.53 ms
000da7a 454.46 ms 445.00 ms -9.46 ms

App size

Revision Plain With Sentry Diff
818a608 17.75 MiB 19.68 MiB 1.94 MiB
8d89cc9+dirty 17.75 MiB 19.68 MiB 1.94 MiB
d916aa3 17.75 MiB 20.15 MiB 2.41 MiB
20d5eaa 17.75 MiB 20.15 MiB 2.41 MiB
1853710 17.75 MiB 19.68 MiB 1.94 MiB
c1573b3 17.75 MiB 20.15 MiB 2.41 MiB
9f211e3 17.75 MiB 19.68 MiB 1.94 MiB
e2fa43d 17.75 MiB 20.15 MiB 2.41 MiB
7be1f99 17.75 MiB 20.15 MiB 2.41 MiB
000da7a 17.75 MiB 19.68 MiB 1.94 MiB

Previous results on branch: fix/logs/replay

Startup times

Revision Plain With Sentry Diff
db9cc97+dirty 434.12 ms 429.16 ms -4.96 ms
997f67a+dirty 416.67 ms 430.36 ms 13.69 ms
3464ac1 386.54 ms 388.55 ms 2.01 ms
6c5d51d 359.48 ms 373.73 ms 14.26 ms

App size

Revision Plain With Sentry Diff
db9cc97+dirty 17.75 MiB 19.68 MiB 1.94 MiB
997f67a+dirty 17.75 MiB 19.68 MiB 1.94 MiB
3464ac1 17.75 MiB 19.68 MiB 1.94 MiB
6c5d51d 17.75 MiB 19.68 MiB 1.94 MiB

Copy link
Contributor

github-actions bot commented Sep 12, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 363.93 ms 426.00 ms 62.07 ms
Size 7.15 MiB 8.41 MiB 1.26 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d916aa3+dirty 411.72 ms 451.76 ms 40.03 ms
c9e95bd+dirty 339.32 ms 401.24 ms 61.92 ms
c08359e+dirty 406.04 ms 428.87 ms 22.83 ms
8d89cc9+dirty 357.69 ms 415.79 ms 58.10 ms
a0b15d6+dirty 414.33 ms 448.85 ms 34.52 ms
b3b5b0d+dirty 361.42 ms 403.90 ms 42.48 ms
7be1f99+dirty 369.02 ms 399.60 ms 30.58 ms
20d5eaa+dirty 358.31 ms 442.37 ms 84.06 ms
a02e30b+dirty 346.13 ms 381.76 ms 35.62 ms
64cd15c+dirty 488.79 ms 483.54 ms -5.24 ms

App size

Revision Plain With Sentry Diff
d916aa3+dirty 7.15 MiB 8.42 MiB 1.27 MiB
c9e95bd+dirty 7.15 MiB 8.41 MiB 1.26 MiB
c08359e+dirty 7.15 MiB 8.42 MiB 1.27 MiB
8d89cc9+dirty 7.15 MiB 8.41 MiB 1.26 MiB
a0b15d6+dirty 7.15 MiB 8.42 MiB 1.27 MiB
b3b5b0d+dirty 7.15 MiB 8.41 MiB 1.26 MiB
7be1f99+dirty 7.15 MiB 8.42 MiB 1.27 MiB
20d5eaa+dirty 7.15 MiB 8.42 MiB 1.27 MiB
a02e30b+dirty 7.15 MiB 8.42 MiB 1.27 MiB
64cd15c+dirty 7.15 MiB 8.42 MiB 1.27 MiB

Previous results on branch: fix/logs/replay

Startup times

Revision Plain With Sentry Diff
3464ac1+dirty 350.41 ms 422.22 ms 71.82 ms
db9cc97+dirty 370.84 ms 387.31 ms 16.46 ms
6c5d51d+dirty 332.77 ms 372.73 ms 39.96 ms
997f67a+dirty 508.00 ms 555.73 ms 47.73 ms

App size

Revision Plain With Sentry Diff
3464ac1+dirty 7.15 MiB 8.41 MiB 1.26 MiB
db9cc97+dirty 7.15 MiB 8.41 MiB 1.26 MiB
6c5d51d+dirty 7.15 MiB 8.41 MiB 1.26 MiB
997f67a+dirty 7.15 MiB 8.41 MiB 1.26 MiB

Copy link
Contributor

github-actions bot commented Sep 12, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1221.15 ms 1226.78 ms 5.63 ms
Size 2.63 MiB 3.96 MiB 1.33 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
20daa0a+dirty 1233.12 ms 1233.35 ms 0.22 ms
ba75c7c+dirty 1235.86 ms 1226.45 ms -9.41 ms
000da7a+dirty 1214.31 ms 1221.91 ms 7.61 ms
23080e5+dirty 1216.02 ms 1224.94 ms 8.91 ms
8ece263+dirty 1217.29 ms 1213.35 ms -3.94 ms
eb07ba3+dirty 1222.46 ms 1220.37 ms -2.08 ms
d916aa3+dirty 1221.02 ms 1228.98 ms 7.96 ms
3e0a5f9+dirty 1226.94 ms 1230.02 ms 3.08 ms
c08359e+dirty 1235.25 ms 1233.96 ms -1.29 ms
64cd15c+dirty 1216.31 ms 1214.04 ms -2.26 ms

App size

Revision Plain With Sentry Diff
20daa0a+dirty 2.63 MiB 3.81 MiB 1.18 MiB
ba75c7c+dirty 2.63 MiB 3.81 MiB 1.18 MiB
000da7a+dirty 2.63 MiB 3.91 MiB 1.28 MiB
23080e5+dirty 2.63 MiB 3.91 MiB 1.28 MiB
8ece263+dirty 2.63 MiB 3.91 MiB 1.28 MiB
eb07ba3+dirty 2.63 MiB 3.81 MiB 1.18 MiB
d916aa3+dirty 2.63 MiB 3.81 MiB 1.18 MiB
3e0a5f9+dirty 2.63 MiB 3.81 MiB 1.18 MiB
c08359e+dirty 2.63 MiB 3.81 MiB 1.18 MiB
64cd15c+dirty 2.63 MiB 3.81 MiB 1.18 MiB

Previous results on branch: fix/logs/replay

Startup times

Revision Plain With Sentry Diff
997f67a+dirty 1227.48 ms 1213.81 ms -13.67 ms
db9cc97+dirty 1215.54 ms 1224.27 ms 8.72 ms
3464ac1+dirty 1229.26 ms 1227.77 ms -1.49 ms
6c5d51d+dirty 1238.14 ms 1237.04 ms -1.10 ms

App size

Revision Plain With Sentry Diff
997f67a+dirty 2.63 MiB 3.96 MiB 1.33 MiB
db9cc97+dirty 2.63 MiB 3.96 MiB 1.33 MiB
3464ac1+dirty 2.63 MiB 3.91 MiB 1.28 MiB
6c5d51d+dirty 2.63 MiB 3.91 MiB 1.28 MiB

Copy link
Contributor

github-actions bot commented Sep 12, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1233.49 ms 1236.27 ms 2.78 ms
Size 3.19 MiB 4.53 MiB 1.35 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
20daa0a+dirty 1227.71 ms 1233.72 ms 6.01 ms
ba75c7c+dirty 1236.14 ms 1240.69 ms 4.55 ms
000da7a+dirty 1204.50 ms 1218.94 ms 14.44 ms
23080e5+dirty 1221.39 ms 1222.08 ms 0.70 ms
8ece263+dirty 1206.90 ms 1211.45 ms 4.55 ms
eb07ba3+dirty 1214.49 ms 1221.59 ms 7.10 ms
d916aa3+dirty 1211.02 ms 1221.33 ms 10.31 ms
3e0a5f9+dirty 1233.65 ms 1239.10 ms 5.45 ms
c08359e+dirty 1200.59 ms 1211.81 ms 11.22 ms
64cd15c+dirty 1213.50 ms 1223.54 ms 10.04 ms

App size

Revision Plain With Sentry Diff
20daa0a+dirty 3.19 MiB 4.38 MiB 1.19 MiB
ba75c7c+dirty 3.19 MiB 4.38 MiB 1.19 MiB
000da7a+dirty 3.19 MiB 4.48 MiB 1.29 MiB
23080e5+dirty 3.19 MiB 4.48 MiB 1.29 MiB
8ece263+dirty 3.19 MiB 4.48 MiB 1.29 MiB
eb07ba3+dirty 3.19 MiB 4.38 MiB 1.19 MiB
d916aa3+dirty 3.19 MiB 4.38 MiB 1.19 MiB
3e0a5f9+dirty 3.19 MiB 4.38 MiB 1.19 MiB
c08359e+dirty 3.19 MiB 4.38 MiB 1.19 MiB
64cd15c+dirty 3.19 MiB 4.38 MiB 1.19 MiB

Previous results on branch: fix/logs/replay

Startup times

Revision Plain With Sentry Diff
997f67a+dirty 1233.22 ms 1238.96 ms 5.73 ms
db9cc97+dirty 1233.84 ms 1234.71 ms 0.87 ms
3464ac1+dirty 1221.94 ms 1225.67 ms 3.73 ms
6c5d51d+dirty 1242.35 ms 1252.60 ms 10.25 ms

App size

Revision Plain With Sentry Diff
997f67a+dirty 3.19 MiB 4.53 MiB 1.35 MiB
db9cc97+dirty 3.19 MiB 4.53 MiB 1.35 MiB
3464ac1+dirty 3.19 MiB 4.48 MiB 1.29 MiB
6c5d51d+dirty 3.19 MiB 4.48 MiB 1.29 MiB

@lucas-zimerman
Copy link
Collaborator Author

Changelog will be updated soon after the next release.

@lucas-zimerman lucas-zimerman changed the title Fix(Logs): Add mobile replay attributes to logs Feat(Logs): Add mobile replay attributes to logs Sep 15, 2025
@lucas-zimerman lucas-zimerman marked this pull request as ready for review September 15, 2025 15:38
Copy link
Contributor

@alwx alwx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@lucas-zimerman lucas-zimerman enabled auto-merge (squash) September 19, 2025 12:42
@lucas-zimerman
Copy link
Collaborator Author

replays are now correctly shown on the UI, so I am merging this PR.

@lucas-zimerman lucas-zimerman merged commit 6469ab0 into main Sep 19, 2025
58 of 65 checks passed
@lucas-zimerman lucas-zimerman deleted the fix/logs/replay branch September 19, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sentry.replay_id to react native logs
3 participants