feat: Bump to Sentry Javascript V9 #4568

lucas-zimerman · 2025-02-19T12:37:45Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

This PR bumps JavaScript to version V9 and also fixes any break changes found.
In short, normal users not experience any changes, as shown on the sample apps, there were no required changes for this bump.

Changes handled:

In regard to shutdownTimeout, we can keep it as an additional parameter or completely remove it if that is the plan.

💡 Motivation and Context

💚 How did you test it?

Sample App, CI, Sentry.io discover

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

Update Changelog with breakchanges.
Create Migration Doc.

#skip-changelog for now

github-actions · 2025-02-19T13:01:43Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1220.76 ms	1214.90 ms	-5.86 ms
Size	2.63 MiB	3.75 MiB	1.12 MiB

Baseline results on branch: v7

Startup times

Revision	Plain	With Sentry	Diff
`9da5c4e`+dirty	1231.84 ms	1235.49 ms	3.65 ms

App size

Revision	Plain	With Sentry	Diff
`9da5c4e`+dirty	2.63 MiB	3.76 MiB	1.13 MiB

Previous results on branch: lz/bump/jsv9

Startup times

Revision	Plain	With Sentry	Diff
`987dc4d`+dirty	1216.13 ms	1227.20 ms	11.08 ms
`35eb9e7`+dirty	1213.46 ms	1221.42 ms	7.96 ms
`71f7309`+dirty	1222.02 ms	1224.81 ms	2.79 ms
`345e497`+dirty	1218.83 ms	1218.73 ms	-0.10 ms
`e54b1ed`+dirty	1227.33 ms	1254.46 ms	27.14 ms
`49f1a9c`+dirty	1220.19 ms	1230.58 ms	10.39 ms
`e468cd4`+dirty	1214.60 ms	1219.63 ms	5.04 ms

App size

Revision	Plain	With Sentry	Diff
`987dc4d`+dirty	2.63 MiB	3.73 MiB	1.10 MiB
`35eb9e7`+dirty	2.63 MiB	3.73 MiB	1.10 MiB
`71f7309`+dirty	2.63 MiB	3.73 MiB	1.10 MiB
`345e497`+dirty	2.63 MiB	3.68 MiB	1.05 MiB
`e54b1ed`+dirty	2.63 MiB	3.68 MiB	1.05 MiB
`49f1a9c`+dirty	2.63 MiB	3.75 MiB	1.12 MiB
`e468cd4`+dirty	2.63 MiB	3.75 MiB	1.12 MiB

github-actions · 2025-02-19T13:26:37Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	428.71 ms	429.00 ms	0.29 ms
Size	17.75 MiB	20.15 MiB	2.40 MiB

Baseline results on branch: v7

Startup times

Revision	Plain	With Sentry	Diff
`9da5c4e`	478.08 ms	467.46 ms	-10.63 ms

App size

Revision	Plain	With Sentry	Diff
`9da5c4e`	17.75 MiB	20.16 MiB	2.41 MiB

Previous results on branch: lz/bump/jsv9

Startup times

Revision	Plain	With Sentry	Diff
`987dc4d`	422.12 ms	478.34 ms	56.22 ms
`71f7309`	412.45 ms	431.62 ms	19.18 ms
`49f1a9c`	423.64 ms	411.10 ms	-12.54 ms
`e54b1ed`	434.79 ms	429.52 ms	-5.27 ms
`e468cd4`	403.30 ms	404.98 ms	1.68 ms
`345e497`	397.98 ms	423.40 ms	25.42 ms
`35eb9e7`	383.45 ms	415.65 ms	32.21 ms

App size

Revision	Plain	With Sentry	Diff
`987dc4d`	17.75 MiB	20.10 MiB	2.36 MiB
`71f7309`	17.75 MiB	20.10 MiB	2.36 MiB
`49f1a9c`	17.75 MiB	20.15 MiB	2.40 MiB
`e54b1ed`	17.75 MiB	20.10 MiB	2.36 MiB
`e468cd4`	17.75 MiB	20.15 MiB	2.40 MiB
`345e497`	17.75 MiB	20.10 MiB	2.36 MiB
`35eb9e7`	17.75 MiB	20.10 MiB	2.36 MiB

github-actions · 2025-02-19T13:36:43Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	383.39 ms	391.12 ms	7.73 ms
Size	7.15 MiB	8.41 MiB	1.26 MiB

Baseline results on branch: v7

Startup times

Revision	Plain	With Sentry	Diff
`9da5c4e`+dirty	399.70 ms	407.34 ms	7.64 ms

App size

Revision	Plain	With Sentry	Diff
`9da5c4e`+dirty	7.15 MiB	8.42 MiB	1.27 MiB

Previous results on branch: lz/bump/jsv9

Startup times

Revision	Plain	With Sentry	Diff
`49f1a9c`+dirty	408.02 ms	399.80 ms	-8.22 ms
`e54b1ed`+dirty	435.06 ms	429.19 ms	-5.87 ms
`e468cd4`+dirty	382.67 ms	399.64 ms	16.97 ms
`987dc4d`+dirty	411.89 ms	418.60 ms	6.71 ms
`345e497`+dirty	375.33 ms	377.23 ms	1.90 ms
`71f7309`+dirty	361.15 ms	369.90 ms	8.75 ms
`35eb9e7`+dirty	426.84 ms	453.53 ms	26.69 ms

App size

Revision	Plain	With Sentry	Diff
`49f1a9c`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`e54b1ed`+dirty	7.15 MiB	8.37 MiB	1.22 MiB
`e468cd4`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`987dc4d`+dirty	7.15 MiB	8.37 MiB	1.22 MiB
`345e497`+dirty	7.15 MiB	8.37 MiB	1.22 MiB
`71f7309`+dirty	7.15 MiB	8.37 MiB	1.22 MiB
`35eb9e7`+dirty	7.15 MiB	8.37 MiB	1.22 MiB

github-actions · 2025-02-19T13:48:55Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1229.55 ms	1231.68 ms	2.13 ms
Size	3.19 MiB	4.32 MiB	1.13 MiB

Baseline results on branch: v7

Startup times

Revision	Plain	With Sentry	Diff
`9da5c4e`+dirty	1215.41 ms	1226.38 ms	10.97 ms

App size

Revision	Plain	With Sentry	Diff
`9da5c4e`+dirty	3.19 MiB	4.33 MiB	1.14 MiB

Previous results on branch: lz/bump/jsv9

Startup times

Revision	Plain	With Sentry	Diff
`987dc4d`+dirty	1209.94 ms	1215.25 ms	5.31 ms
`35eb9e7`+dirty	1219.31 ms	1217.37 ms	-1.94 ms
`71f7309`+dirty	1206.00 ms	1214.28 ms	8.28 ms
`345e497`+dirty	1210.67 ms	1207.50 ms	-3.17 ms
`e54b1ed`+dirty	1227.90 ms	1230.92 ms	3.02 ms
`49f1a9c`+dirty	1218.65 ms	1217.25 ms	-1.40 ms
`e468cd4`+dirty	1230.35 ms	1240.34 ms	9.99 ms

App size

Revision	Plain	With Sentry	Diff
`987dc4d`+dirty	3.19 MiB	4.30 MiB	1.11 MiB
`35eb9e7`+dirty	3.19 MiB	4.30 MiB	1.11 MiB
`71f7309`+dirty	3.19 MiB	4.30 MiB	1.11 MiB
`345e497`+dirty	3.19 MiB	4.25 MiB	1.06 MiB
`e54b1ed`+dirty	3.19 MiB	4.25 MiB	1.06 MiB
`49f1a9c`+dirty	3.19 MiB	4.32 MiB	1.13 MiB
`e468cd4`+dirty	3.19 MiB	4.32 MiB	1.13 MiB

lucas-zimerman · 2025-02-24T14:31:54Z

I will wait for some information in regard to getsentry/sentry-javascript#15471 in case it's a problem on the JavaScript SDK

krystofwoldrich · 2025-02-25T10:21:46Z

@lucas-zimerman The yarn.lock seems to be completely regenerated.

How have you upgraded to the JS v9?

We should review it and ensure only the @sentry/* are upgraded to avoid issues like #4592

The yarn.lock change should be readable as only sentry deps should change.

lucas-zimerman · 2025-02-25T14:00:48Z

@lucas-zimerman The yarn.lock seems to be completely regenerated.

How have you upgraded to the JS v9?

We should review it and ensure only the @sentry/* are upgraded to avoid issues like #4592

The yarn.lock change should be readable as only sentry deps should change.

I fixed on 028dbf9, At the time there were a conflict with yarn.lock, and I created a new one. Next time I will get the target branch yarn.lock and install again on the PR

packages/core/package.json

krystofwoldrich · 2025-02-25T14:07:13Z

Thank you @lucas-zimerman, now the yarn.lock looks good.

packages/core/src/js/tracing/span.ts

lucas-zimerman · 2025-02-25T18:38:44Z

@antonis @krystofwoldrich I'd say now it's ready for review :D

packages/core/package.json

packages/core/src/js/integrations/reactnativeerrorhandlers.ts

packages/core/test/feedback.test.ts

packages/core/test/tracing/addTracingExtensions.test.ts

packages/core/test/tracing/timetodisplaynative.web.test.tsx

packages/core/test/utils/safe.test.ts

packages/core/test/tracing/integrations/userInteraction.test.ts

krystofwoldrich · 2025-03-12T19:57:53Z

Overall the PR looks good. Thank you for all the changes.

I have just a few suggestions and some questions to understand the v9 changes.

krystofwoldrich · 2025-03-20T10:58:32Z

Looks good, thank you for all the comments, changes and explanations.

Two things we should do in a follow-up PRs:

Update the type of options?.profilerProps feat: Bump to Sentry Javascript V9 #4568 (comment)
Auto add browserSessionIntegration feat: Bump to Sentry Javascript V9 #4568 (comment)
Use getMainCarrier feat: Bump to Sentry Javascript V9 #4568 (comment)

One item to finalize this PR:

Update the mock of the UIManager to test the RN Web version of the components. feat: Bump to Sentry Javascript V9 #4568 (comment)

packages/core/src/js/transports/encodePolyfill.ts

lucas-zimerman · 2025-04-07T13:36:27Z

Looks good, thank you for all the comments, changes and explanations.

Two things we should do in a follow-up PRs:

* Update the type of `options?.profilerProps` [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005203769)

* Auto add `browserSessionIntegration` [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005088065)

* Use `getMainCarrier` [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005519564)

One item to finalize this PR:

* Update the mock of the UIManager to test the RN Web version of the components. [feat: Bump to Sentry Javascript V9 #4568 (comment)](https://github.com/getsentry/sentry-react-native/pull/4568#discussion_r2005309689)

I have added your notes here so we don't lose them #4542

… version on samples and e2e

krystofwoldrich

Thank you for bumping RN to JS v9.

Looks good!

lucas-zimerman added 4 commits February 14, 2025 14:02

bump SDKs

04b6c06

bump SDKs

0dc4bca

fix build

382fef6

fix tests

33af36c

fix tests

ad6a76c

lucas-zimerman added 3 commits February 19, 2025 11:17

fix lint errors

15342a2

test ts 5.0

c267f9b

rollback

efea84f

antonis mentioned this pull request Feb 19, 2025

chore(deps): Fixes JS SDK v9 breakages #4566

Closed

10 tasks

lucas-zimerman added the Blocked label Feb 24, 2025

Merge branch 'v7' into lz/bump/jsv9

65a10d5

antonis mentioned this pull request Feb 25, 2025

chore(dep): fix expo sample version to 52.0.19 #4592

Closed

10 tasks

lucas-zimerman removed the Blocked label Feb 25, 2025

krystofwoldrich reviewed Feb 25, 2025

View reviewed changes

packages/core/package.json Outdated Show resolved Hide resolved

lucas-zimerman commented Feb 25, 2025

View reviewed changes

packages/core/src/js/tracing/span.ts Show resolved Hide resolved

lucas-zimerman added 2 commits February 25, 2025 13:16

fix merge conflict with yarn

028dbf9

fix new lint issue

a57459a

lucas-zimerman marked this pull request as ready for review February 25, 2025 18:37

lucas-zimerman requested a review from antonis as a code owner February 25, 2025 18:37

antonis reviewed Feb 26, 2025

View reviewed changes

packages/core/package.json Outdated Show resolved Hide resolved

antonis reviewed Feb 26, 2025

View reviewed changes

packages/core/src/js/integrations/reactnativeerrorhandlers.ts Outdated Show resolved Hide resolved