chore(feedback): Use Widget instead of Form #4547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystofwoldrich
requested review from
lucas-zimerman and
antonis
as code owners
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Use Widget instead of Form ([#4547](https://github.com/getsentry/sentry-react-native/pull/4547))If none of the above apply, you can opt out of this check by adding |
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0459aee | 491.48 ms | 486.13 ms | -5.35 ms |
| e5d5735 | 452.70 ms | 453.04 ms | 0.34 ms |
| 269c976 | 448.08 ms | 428.86 ms | -19.22 ms |
| 2646c98 | 429.98 ms | 421.63 ms | -8.35 ms |
| 0325426 | 477.32 ms | 457.43 ms | -19.89 ms |
| 3e4cdf5 | 462.35 ms | 474.96 ms | 12.61 ms |
| 8cb898b | 438.83 ms | 420.58 ms | -18.25 ms |
| 6b1624f | 462.78 ms | 465.13 ms | 2.35 ms |
| df05370 | 477.62 ms | 491.63 ms | 14.00 ms |
| 894ebb0 | 497.45 ms | 545.04 ms | 47.60 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0459aee | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| e5d5735 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| 269c976 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| 2646c98 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| 0325426 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| 3e4cdf5 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| 8cb898b | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| 6b1624f | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| df05370 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| 894ebb0 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3e4cdf5+dirty | 642.13 ms | 702.23 ms | 60.10 ms |
| 269c976+dirty | 395.13 ms | 438.37 ms | 43.24 ms |
| 8cb898b+dirty | 393.33 ms | 416.20 ms | 22.87 ms |
| 894ebb0+dirty | 417.81 ms | 499.74 ms | 81.93 ms |
| 2646c98+dirty | 415.13 ms | 438.41 ms | 23.28 ms |
| 9402883+dirty | 436.49 ms | 518.94 ms | 82.45 ms |
| 6b1624f+dirty | 382.17 ms | 441.00 ms | 58.83 ms |
| 0325426+dirty | 418.89 ms | 485.00 ms | 66.11 ms |
| df05370+dirty | 395.08 ms | 430.38 ms | 35.30 ms |
| 77e88fc+dirty | 358.67 ms | 346.20 ms | -12.47 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3e4cdf5+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| 269c976+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| 8cb898b+dirty | 7.15 MiB | 8.39 MiB | 1.24 MiB |
| 894ebb0+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| 2646c98+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| 9402883+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| 6b1624f+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| 0325426+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| df05370+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| 77e88fc+dirty | 7.15 MiB | 8.39 MiB | 1.24 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2646c98+dirty | 1218.51 ms | 1218.92 ms | 0.41 ms |
| 269c976+dirty | 1210.02 ms | 1204.46 ms | -5.56 ms |
| e5d5735+dirty | 1222.02 ms | 1222.22 ms | 0.20 ms |
| df05370+dirty | 1209.92 ms | 1216.55 ms | 6.63 ms |
| 894ebb0+dirty | 1224.33 ms | 1214.45 ms | -9.89 ms |
| 9402883+dirty | 1219.65 ms | 1217.94 ms | -1.72 ms |
| 77e88fc+dirty | 1224.55 ms | 1232.41 ms | 7.86 ms |
| 3e4cdf5+dirty | 1222.53 ms | 1224.42 ms | 1.89 ms |
| 0325426+dirty | 1228.88 ms | 1229.92 ms | 1.04 ms |
| 8cb898b+dirty | 1221.40 ms | 1231.78 ms | 10.37 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2646c98+dirty | 2.63 MiB | 3.69 MiB | 1.06 MiB |
| 269c976+dirty | 2.63 MiB | 3.69 MiB | 1.06 MiB |
| e5d5735+dirty | 2.63 MiB | 3.69 MiB | 1.06 MiB |
| df05370+dirty | 2.63 MiB | 3.71 MiB | 1.07 MiB |
| 894ebb0+dirty | 2.63 MiB | 3.71 MiB | 1.07 MiB |
| 9402883+dirty | 2.63 MiB | 3.71 MiB | 1.07 MiB |
| 77e88fc+dirty | 2.63 MiB | 3.75 MiB | 1.12 MiB |
| 3e4cdf5+dirty | 2.63 MiB | 3.69 MiB | 1.06 MiB |
| 0325426+dirty | 2.63 MiB | 3.69 MiB | 1.06 MiB |
| 8cb898b+dirty | 2.63 MiB | 3.71 MiB | 1.08 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2646c98+dirty | 1239.94 ms | 1246.90 ms | 6.96 ms |
| 269c976+dirty | 1223.29 ms | 1222.90 ms | -0.39 ms |
| e5d5735+dirty | 1217.78 ms | 1221.80 ms | 4.02 ms |
| df05370+dirty | 1221.14 ms | 1216.60 ms | -4.55 ms |
| 894ebb0+dirty | 1210.94 ms | 1202.08 ms | -8.85 ms |
| 9402883+dirty | 1217.71 ms | 1213.02 ms | -4.69 ms |
| 77e88fc+dirty | 1218.79 ms | 1220.00 ms | 1.21 ms |
| 3e4cdf5+dirty | 1213.36 ms | 1221.31 ms | 7.95 ms |
| 0325426+dirty | 1210.17 ms | 1216.37 ms | 6.20 ms |
| 8cb898b+dirty | 1209.39 ms | 1207.57 ms | -1.82 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2646c98+dirty | 3.19 MiB | 4.26 MiB | 1.07 MiB |
| 269c976+dirty | 3.19 MiB | 4.26 MiB | 1.07 MiB |
| e5d5735+dirty | 3.19 MiB | 4.26 MiB | 1.07 MiB |
| df05370+dirty | 3.19 MiB | 4.27 MiB | 1.09 MiB |
| 894ebb0+dirty | 3.19 MiB | 4.27 MiB | 1.09 MiB |
| 9402883+dirty | 3.19 MiB | 4.27 MiB | 1.09 MiB |
| 77e88fc+dirty | 3.19 MiB | 4.32 MiB | 1.13 MiB |
| 3e4cdf5+dirty | 3.19 MiB | 4.26 MiB | 1.07 MiB |
| 0325426+dirty | 3.19 MiB | 4.26 MiB | 1.07 MiB |
| 8cb898b+dirty | 3.19 MiB | 4.28 MiB | 1.09 MiB |
# Conflicts: # packages/core/src/js/feedback/FeedbackWidgetManager.tsx
antonis
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Thank you for tackling this @krystofwoldrich 🙇
LGTM 🚀
Also taking a note to update the docs getsentry/sentry-docs#12503
This was referenced Feb 17, 2025
Updated with getsentry/sentry-docs@639f64d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny change, many lines,
when I was looking at the docs, we refer to the feedback component as a feedback widget at most places.