feat(feedback): Show selected screenshot #4545

antonis · 2025-02-14T15:56:41Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

Based on #4538 to avoid conflicts

📜 Description

Shows selected screenshot in the UI. The screenshot was positioned at the left of the screenshot button similar to Cocoa.

Cocoa	RN Android	RN iOS

⚠️ The docs PR needs to be updated with the added styles getsentry/sentry-docs#12503

💡 Motivation and Context

See #4302

💚 How did you test it?

Manual, CI

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog

github-actions · 2025-02-14T16:08:28Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	419.18 ms	411.71 ms	-7.48 ms
Size	17.75 MiB	20.12 MiB	2.38 MiB

Baseline results on branch: feedback-ui

Startup times

Revision	Plain	With Sentry	Diff
`9402883`	448.53 ms	468.73 ms	20.20 ms
`e42816c`	401.30 ms	410.04 ms	8.74 ms
`3e4cdf5`	462.35 ms	474.96 ms	12.61 ms
`77e88fc`	478.48 ms	487.21 ms	8.73 ms
`8cb898b`	438.83 ms	420.58 ms	-18.25 ms
`2646c98`	429.98 ms	421.63 ms	-8.35 ms
`6b1624f`	462.78 ms	465.13 ms	2.35 ms
`df05370`	477.62 ms	491.63 ms	14.00 ms
`e5d5735`	452.70 ms	453.04 ms	0.34 ms
`894ebb0`	497.45 ms	545.04 ms	47.60 ms

App size

Revision	Plain	With Sentry	Diff
`9402883`	17.75 MiB	20.12 MiB	2.37 MiB
`e42816c`	17.75 MiB	20.12 MiB	2.38 MiB
`3e4cdf5`	17.75 MiB	20.12 MiB	2.37 MiB
`77e88fc`	17.75 MiB	20.12 MiB	2.37 MiB
`8cb898b`	17.75 MiB	20.12 MiB	2.37 MiB
`2646c98`	17.75 MiB	20.12 MiB	2.37 MiB
`6b1624f`	17.75 MiB	20.12 MiB	2.37 MiB
`df05370`	17.75 MiB	20.12 MiB	2.37 MiB
`e5d5735`	17.75 MiB	20.12 MiB	2.37 MiB
`894ebb0`	17.75 MiB	20.12 MiB	2.37 MiB

Previous results on branch: antonis/feedback-show-screenshot

Startup times

Revision	Plain	With Sentry	Diff
`2c77656`	483.83 ms	525.81 ms	41.98 ms
`ae7dd36`	470.36 ms	466.64 ms	-3.72 ms
`efb4f02`	465.47 ms	450.27 ms	-15.20 ms
`02906ad`	425.30 ms	426.66 ms	1.36 ms

App size

Revision	Plain	With Sentry	Diff
`2c77656`	17.75 MiB	20.12 MiB	2.38 MiB
`ae7dd36`	17.75 MiB	20.12 MiB	2.38 MiB
`efb4f02`	17.75 MiB	20.12 MiB	2.38 MiB
`02906ad`	17.75 MiB	20.12 MiB	2.38 MiB

github-actions · 2025-02-14T16:17:18Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	404.87 ms	411.18 ms	6.31 ms
Size	7.15 MiB	8.39 MiB	1.24 MiB

Baseline results on branch: feedback-ui

Startup times

Revision	Plain	With Sentry	Diff
`e42816c`+dirty	347.06 ms	348.18 ms	1.12 ms
`269c976`+dirty	395.13 ms	438.37 ms	43.24 ms
`2646c98`+dirty	415.13 ms	438.41 ms	23.28 ms
`d1a10a1`+dirty	364.43 ms	362.98 ms	-1.45 ms
`3e4cdf5`+dirty	642.13 ms	702.23 ms	60.10 ms
`6b1624f`+dirty	382.17 ms	441.00 ms	58.83 ms
`0325426`+dirty	418.89 ms	485.00 ms	66.11 ms
`894ebb0`+dirty	417.81 ms	499.74 ms	81.93 ms
`9402883`+dirty	436.49 ms	518.94 ms	82.45 ms
`e5d5735`+dirty	377.37 ms	430.04 ms	52.67 ms

App size

Revision	Plain	With Sentry	Diff
`e42816c`+dirty	7.15 MiB	8.39 MiB	1.24 MiB
`269c976`+dirty	7.15 MiB	8.39 MiB	1.23 MiB
`2646c98`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`d1a10a1`+dirty	7.15 MiB	8.39 MiB	1.24 MiB
`3e4cdf5`+dirty	7.15 MiB	8.39 MiB	1.23 MiB
`6b1624f`+dirty	7.15 MiB	8.39 MiB	1.23 MiB
`0325426`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`894ebb0`+dirty	7.15 MiB	8.39 MiB	1.23 MiB
`9402883`+dirty	7.15 MiB	8.39 MiB	1.23 MiB
`e5d5735`+dirty	7.15 MiB	8.39 MiB	1.23 MiB

Previous results on branch: antonis/feedback-show-screenshot

Startup times

Revision	Plain	With Sentry	Diff
`02906ad`+dirty	418.55 ms	442.74 ms	24.19 ms
`2c77656`+dirty	356.80 ms	337.33 ms	-19.47 ms
`ae7dd36`+dirty	399.65 ms	391.49 ms	-8.16 ms
`efb4f02`+dirty	445.25 ms	444.89 ms	-0.36 ms

App size

Revision	Plain	With Sentry	Diff
`02906ad`+dirty	7.15 MiB	8.39 MiB	1.24 MiB
`2c77656`+dirty	7.15 MiB	8.39 MiB	1.24 MiB
`ae7dd36`+dirty	7.15 MiB	8.39 MiB	1.24 MiB
`efb4f02`+dirty	7.15 MiB	8.39 MiB	1.24 MiB

github-actions · 2025-02-14T16:21:03Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1222.94 ms	1226.90 ms	3.96 ms
Size	2.63 MiB	3.76 MiB	1.12 MiB

Baseline results on branch: feedback-ui

Startup times

Revision	Plain	With Sentry	Diff
`e5d5735`+dirty	1222.02 ms	1222.22 ms	0.20 ms
`8cb898b`+dirty	1221.40 ms	1231.78 ms	10.37 ms
`77e88fc`+dirty	1224.55 ms	1232.41 ms	7.86 ms
`9402883`+dirty	1219.65 ms	1217.94 ms	-1.72 ms
`894ebb0`+dirty	1224.33 ms	1214.45 ms	-9.89 ms
`e42816c`+dirty	1211.29 ms	1219.65 ms	8.37 ms
`0325426`+dirty	1228.88 ms	1229.92 ms	1.04 ms
`0459aee`+dirty	1232.82 ms	1231.19 ms	-1.63 ms
`6b1624f`+dirty	1224.65 ms	1225.65 ms	1.00 ms
`269c976`+dirty	1210.02 ms	1204.46 ms	-5.56 ms

App size

Revision	Plain	With Sentry	Diff
`e5d5735`+dirty	2.63 MiB	3.69 MiB	1.06 MiB
`8cb898b`+dirty	2.63 MiB	3.71 MiB	1.08 MiB
`77e88fc`+dirty	2.63 MiB	3.75 MiB	1.12 MiB
`9402883`+dirty	2.63 MiB	3.71 MiB	1.07 MiB
`894ebb0`+dirty	2.63 MiB	3.71 MiB	1.07 MiB
`e42816c`+dirty	2.63 MiB	3.75 MiB	1.12 MiB
`0325426`+dirty	2.63 MiB	3.69 MiB	1.06 MiB
`0459aee`+dirty	2.63 MiB	3.69 MiB	1.06 MiB
`6b1624f`+dirty	2.63 MiB	3.71 MiB	1.07 MiB
`269c976`+dirty	2.63 MiB	3.69 MiB	1.06 MiB

Previous results on branch: antonis/feedback-show-screenshot

Startup times

Revision	Plain	With Sentry	Diff
`02906ad`+dirty	1216.76 ms	1222.88 ms	6.12 ms
`efb4f02`+dirty	1211.04 ms	1234.25 ms	23.21 ms
`ae7dd36`+dirty	1229.00 ms	1232.82 ms	3.82 ms
`2c77656`+dirty	1228.80 ms	1232.26 ms	3.46 ms

App size

Revision	Plain	With Sentry	Diff
`02906ad`+dirty	2.63 MiB	3.75 MiB	1.12 MiB
`efb4f02`+dirty	2.63 MiB	3.76 MiB	1.12 MiB
`ae7dd36`+dirty	2.63 MiB	3.75 MiB	1.12 MiB
`2c77656`+dirty	2.63 MiB	3.76 MiB	1.12 MiB

github-actions · 2025-02-14T16:30:12Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1220.76 ms	1223.32 ms	2.56 ms
Size	3.19 MiB	4.32 MiB	1.14 MiB

Baseline results on branch: feedback-ui

Startup times

Revision	Plain	With Sentry	Diff
`e5d5735`+dirty	1217.78 ms	1221.80 ms	4.02 ms
`8cb898b`+dirty	1209.39 ms	1207.57 ms	-1.82 ms
`77e88fc`+dirty	1218.79 ms	1220.00 ms	1.21 ms
`9402883`+dirty	1217.71 ms	1213.02 ms	-4.69 ms
`894ebb0`+dirty	1210.94 ms	1202.08 ms	-8.85 ms
`e42816c`+dirty	1220.08 ms	1222.46 ms	2.38 ms
`0325426`+dirty	1210.17 ms	1216.37 ms	6.20 ms
`0459aee`+dirty	1233.67 ms	1239.80 ms	6.12 ms
`6b1624f`+dirty	1224.12 ms	1220.73 ms	-3.39 ms
`269c976`+dirty	1223.29 ms	1222.90 ms	-0.39 ms

App size

Revision	Plain	With Sentry	Diff
`e5d5735`+dirty	3.19 MiB	4.26 MiB	1.07 MiB
`8cb898b`+dirty	3.19 MiB	4.28 MiB	1.09 MiB
`77e88fc`+dirty	3.19 MiB	4.32 MiB	1.13 MiB
`9402883`+dirty	3.19 MiB	4.27 MiB	1.09 MiB
`894ebb0`+dirty	3.19 MiB	4.27 MiB	1.09 MiB
`e42816c`+dirty	3.19 MiB	4.32 MiB	1.13 MiB
`0325426`+dirty	3.19 MiB	4.26 MiB	1.07 MiB
`0459aee`+dirty	3.19 MiB	4.26 MiB	1.07 MiB
`6b1624f`+dirty	3.19 MiB	4.27 MiB	1.09 MiB
`269c976`+dirty	3.19 MiB	4.26 MiB	1.07 MiB

Previous results on branch: antonis/feedback-show-screenshot

Startup times

Revision	Plain	With Sentry	Diff
`02906ad`+dirty	1223.98 ms	1222.76 ms	-1.22 ms
`efb4f02`+dirty	1211.59 ms	1207.47 ms	-4.13 ms
`ae7dd36`+dirty	1230.00 ms	1228.51 ms	-1.49 ms
`2c77656`+dirty	1231.94 ms	1233.08 ms	1.14 ms

App size

Revision	Plain	With Sentry	Diff
`02906ad`+dirty	3.19 MiB	4.32 MiB	1.13 MiB
`efb4f02`+dirty	3.19 MiB	4.32 MiB	1.14 MiB
`ae7dd36`+dirty	3.19 MiB	4.32 MiB	1.14 MiB
`2c77656`+dirty	3.19 MiB	4.32 MiB	1.14 MiB

github-actions · 2025-02-14T16:33:19Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 77516b2

krystofwoldrich

Thank you. Looks and works as expected. 🚀

# Conflicts: # packages/core/src/js/feedback/FeedbackWidget.tsx

…-screenshot # Conflicts: # packages/core/src/js/feedback/FeedbackWidget.tsx

…-screenshot

antonis · 2025-02-18T10:24:04Z

⚠️ The docs PR needs to be updated with the added styles getsentry/sentry-docs#12503

Updated with getsentry/sentry-docs@440b0c6

# Conflicts: # packages/core/src/js/feedback/FeedbackWidget.tsx

antonis added 2 commits February 14, 2025 13:47

Save form state for unsubmitted data

38a6085

Show selected screenshot

56a113e

This was referenced Feb 14, 2025

[EPIC] Feedback Widget for React Native #4302

Open

feat: Feedback Widget Beta for React Native #4435

Merged

antonis marked this pull request as ready for review February 14, 2025 16:02

antonis requested review from krystofwoldrich and lucas-zimerman as code owners February 14, 2025 16:02

antonis mentioned this pull request Feb 14, 2025

feat(feedback): Use only image uri in the onAddScreenshot callback #4546

Merged

10 tasks

antonis changed the title ~~Feedback UI: Show selected screenshot~~ feat(feedback): Show selected screenshot Feb 14, 2025

krystofwoldrich approved these changes Feb 14, 2025

View reviewed changes

antonis added 11 commits February 17, 2025 12:02

Merge branch 'feedback-ui' into antonis/feedback-save-state

9212cb8

# Conflicts: # packages/core/src/js/feedback/FeedbackWidget.tsx

Omit isVisible from state

1efb23e

Save/clear form state on unmount

59f2f57

Pass the missing attachment parameter in the onSubmitSuccess

797611f

Merge branch 'antonis/feedback-save-state' into antonis/feedback-show…

dbf8c90

…-screenshot # Conflicts: # packages/core/src/js/feedback/FeedbackWidget.tsx

Merge branch 'feedback-ui' into antonis/feedback-save-state

e63ee11

Merge branch 'antonis/feedback-save-state' into antonis/feedback-show…

f220540

…-screenshot

Use instance variable for _didSubmitForm

f17106e

Merge branch 'antonis/feedback-save-state' into antonis/feedback-show…

869f22b

…-screenshot

Fixes lint issue

6e2d6ec

Merge branch 'antonis/feedback-save-state' into antonis/feedback-show…

082ef57

…-screenshot

antonis mentioned this pull request Feb 18, 2025

RN: Add feedback widget documentation getsentry/sentry-docs#12503

Merged

6 tasks

Base automatically changed from antonis/feedback-save-state to feedback-ui February 18, 2025 13:46

Merge branch 'feedback-ui' into antonis/feedback-show-screenshot

69a382f

# Conflicts: # packages/core/src/js/feedback/FeedbackWidget.tsx

Fix merge issue

77516b2

antonis merged commit b3ea2b2 into feedback-ui Feb 18, 2025
66 checks passed

antonis deleted the antonis/feedback-show-screenshot branch February 18, 2025 14:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(feedback): Show selected screenshot #4545

feat(feedback): Show selected screenshot #4545

antonis commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

Baseline results on branch: feedback-ui

Startup times

App size

Previous results on branch: antonis/feedback-show-screenshot

Startup times

App size

github-actions bot commented Feb 14, 2025 •

edited

Loading

Baseline results on branch: feedback-ui

Startup times

App size

Previous results on branch: antonis/feedback-show-screenshot

Startup times

App size

github-actions bot commented Feb 14, 2025 •

edited

Loading

Baseline results on branch: feedback-ui

Startup times

App size

Previous results on branch: antonis/feedback-show-screenshot

Startup times

App size

github-actions bot commented Feb 14, 2025 •

edited

Loading

Baseline results on branch: feedback-ui

Startup times

App size

Previous results on branch: antonis/feedback-show-screenshot

Startup times

App size

github-actions bot commented Feb 14, 2025 •

edited

Loading

krystofwoldrich left a comment

antonis commented Feb 18, 2025

feat(feedback): Show selected screenshot #4545

feat(feedback): Show selected screenshot #4545

Conversation

antonis commented Feb 14, 2025 • edited Loading

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Feb 14, 2025 • edited Loading

Android (legacy) Performance metrics 🚀

Baseline results on branch: feedback-ui

Startup times

App size

Previous results on branch: antonis/feedback-show-screenshot

Startup times

App size

github-actions bot commented Feb 14, 2025 • edited Loading

Android (new) Performance metrics 🚀

Baseline results on branch: feedback-ui

Startup times

App size

Previous results on branch: antonis/feedback-show-screenshot

Startup times

App size

github-actions bot commented Feb 14, 2025 • edited Loading

iOS (legacy) Performance metrics 🚀

Baseline results on branch: feedback-ui

Startup times

App size

Previous results on branch: antonis/feedback-show-screenshot

Startup times

App size

github-actions bot commented Feb 14, 2025 • edited Loading

iOS (new) Performance metrics 🚀

Baseline results on branch: feedback-ui

Startup times

App size

Previous results on branch: antonis/feedback-show-screenshot

Startup times

App size

github-actions bot commented Feb 14, 2025 • edited Loading

krystofwoldrich left a comment

Choose a reason for hiding this comment

antonis commented Feb 18, 2025

antonis commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading