-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(e2e): Bump tests to iOS 18.1 and macos-15 #4273
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystofwoldrich
requested review from
lucas-zimerman and
antonis
as code owners
November 14, 2024 03:01
krystofwoldrich
changed the title
fix(e2e): Bump tests to iPhone 16 and macos-15
fix(e2e): Bump tests to iOS 18.1 and macos-15
Nov 14, 2024
iOS (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e540498+dirty | 1220.61 ms | 1212.93 ms | -7.68 ms |
b95b8af+dirty | 1221.39 ms | 1228.52 ms | 7.13 ms |
5bb8d5f+dirty | 1235.47 ms | 1237.39 ms | 1.92 ms |
eb1e19f+dirty | 1209.56 ms | 1214.94 ms | 5.38 ms |
c2a4e9b+dirty | 1240.10 ms | 1239.22 ms | -0.88 ms |
31fcca2+dirty | 1209.17 ms | 1216.21 ms | 7.04 ms |
1c65324+dirty | 1235.17 ms | 1235.08 ms | -0.09 ms |
8c88ac7+dirty | 1205.13 ms | 1218.87 ms | 13.74 ms |
63ed251+dirty | 1232.55 ms | 1238.77 ms | 6.22 ms |
d2c32bb+dirty | 1223.69 ms | 1229.49 ms | 5.80 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e540498+dirty | 2.36 MiB | 3.14 MiB | 793.34 KiB |
b95b8af+dirty | 2.36 MiB | 3.14 MiB | 793.32 KiB |
5bb8d5f+dirty | 2.36 MiB | 2.92 MiB | 570.22 KiB |
eb1e19f+dirty | 2.36 MiB | 3.08 MiB | 737.21 KiB |
c2a4e9b+dirty | 2.36 MiB | 3.08 MiB | 734.00 KiB |
31fcca2+dirty | 2.36 MiB | 2.90 MiB | 552.95 KiB |
1c65324+dirty | 2.36 MiB | 3.04 MiB | 698.64 KiB |
8c88ac7+dirty | 2.36 MiB | 3.10 MiB | 752.63 KiB |
63ed251+dirty | 2.36 MiB | 3.10 MiB | 752.55 KiB |
d2c32bb+dirty | 2.36 MiB | 3.08 MiB | 737.22 KiB |
iOS (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e540498+dirty | 1254.92 ms | 1247.21 ms | -7.71 ms |
b95b8af+dirty | 1235.60 ms | 1242.06 ms | 6.46 ms |
5bb8d5f+dirty | 1215.04 ms | 1217.52 ms | 2.48 ms |
eb1e19f+dirty | 1229.91 ms | 1231.63 ms | 1.71 ms |
c2a4e9b+dirty | 1247.39 ms | 1243.04 ms | -4.35 ms |
31fcca2+dirty | 1222.04 ms | 1226.51 ms | 4.47 ms |
1c65324+dirty | 1239.71 ms | 1239.86 ms | 0.15 ms |
8c88ac7+dirty | 1240.66 ms | 1247.42 ms | 6.76 ms |
63ed251+dirty | 1223.27 ms | 1222.94 ms | -0.33 ms |
d2c32bb+dirty | 1244.00 ms | 1245.77 ms | 1.77 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e540498+dirty | 2.92 MiB | 3.69 MiB | 794.14 KiB |
b95b8af+dirty | 2.92 MiB | 3.69 MiB | 794.16 KiB |
5bb8d5f+dirty | 2.92 MiB | 3.48 MiB | 575.85 KiB |
eb1e19f+dirty | 2.92 MiB | 3.64 MiB | 742.82 KiB |
c2a4e9b+dirty | 2.92 MiB | 3.64 MiB | 739.91 KiB |
31fcca2+dirty | 2.92 MiB | 3.46 MiB | 557.31 KiB |
1c65324+dirty | 2.92 MiB | 3.61 MiB | 705.56 KiB |
8c88ac7+dirty | 2.92 MiB | 3.66 MiB | 757.12 KiB |
63ed251+dirty | 2.92 MiB | 3.66 MiB | 757.10 KiB |
d2c32bb+dirty | 2.92 MiB | 3.64 MiB | 742.84 KiB |
Android (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
52c0562 | 453.04 ms | 434.71 ms | -18.33 ms |
63ed251 | 457.74 ms | 441.54 ms | -16.20 ms |
baa882f | 354.93 ms | 356.18 ms | 1.25 ms |
c398f67 | 449.64 ms | 461.38 ms | 11.74 ms |
728164b | 414.34 ms | 449.22 ms | 34.88 ms |
e2b64fe | 316.88 ms | 330.23 ms | 13.35 ms |
148f924 | 492.65 ms | 500.28 ms | 7.63 ms |
a5d86e1 | 465.06 ms | 457.83 ms | -7.23 ms |
86d6d2c+dirty | 332.90 ms | 352.45 ms | 19.55 ms |
8c88ac7 | 411.15 ms | 400.54 ms | -10.60 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
52c0562 | 17.73 MiB | 20.11 MiB | 2.38 MiB |
63ed251 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
baa882f | 17.73 MiB | 20.06 MiB | 2.33 MiB |
c398f67 | 17.73 MiB | 19.94 MiB | 2.21 MiB |
728164b | 17.73 MiB | 19.85 MiB | 2.12 MiB |
e2b64fe | 17.73 MiB | 19.80 MiB | 2.07 MiB |
148f924 | 17.73 MiB | 19.94 MiB | 2.21 MiB |
a5d86e1 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
86d6d2c+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
8c88ac7 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
Android (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9cab16b+dirty | 370.82 ms | 416.37 ms | 45.55 ms |
6e8584e+dirty | 383.37 ms | 400.84 ms | 17.47 ms |
31fcca2+dirty | 366.64 ms | 395.78 ms | 29.14 ms |
0d3e677+dirty | 384.24 ms | 431.45 ms | 47.21 ms |
e73d82f+dirty | 377.67 ms | 407.06 ms | 29.39 ms |
ad6c299+dirty | 336.47 ms | 362.89 ms | 26.42 ms |
2534337+dirty | 597.14 ms | 665.04 ms | 67.90 ms |
c398f67+dirty | 315.08 ms | 345.60 ms | 30.52 ms |
5446992+dirty | 371.61 ms | 390.00 ms | 18.39 ms |
80b2ce3+dirty | 271.29 ms | 316.47 ms | 45.18 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9cab16b+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
6e8584e+dirty | 7.15 MiB | 8.13 MiB | 1002.18 KiB |
31fcca2+dirty | 7.15 MiB | 8.18 MiB | 1.03 MiB |
0d3e677+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
e73d82f+dirty | 7.15 MiB | 8.34 MiB | 1.19 MiB |
ad6c299+dirty | 7.15 MiB | 8.04 MiB | 912.17 KiB |
2534337+dirty | 7.15 MiB | 8.11 MiB | 988.68 KiB |
c398f67+dirty | 7.15 MiB | 8.21 MiB | 1.07 MiB |
5446992+dirty | 7.15 MiB | 8.12 MiB | 999.45 KiB |
80b2ce3+dirty | 7.15 MiB | 8.04 MiB | 911.02 KiB |
antonis
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for handling this 🙇
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The E2E Test of RN 0.65 was failing on iPhone 14 simulator lookup.
Corepack is not available in macos-15 at the moment.
#skip-changelog
This PR doesn't fix the sample app provisioning profile issues not the native tests fail.