Skip to content

test: Unfinished span behavior #4546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

szokeasaurusrex
Copy link
Member

Add a test which demonstrates how unfinished spans are handled. We will use this to compare behavior with potel-base


Thank you for contributing to sentry-python! Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval.

Add a test which demonstrates how unfinished spans are handled. We will use this to compare behavior with `potel-base`
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/test-unfinished-spans branch from d31749c to 3f40de3 Compare July 3, 2025 12:25
Copy link

codecov bot commented Jul 3, 2025

❌ 13 Tests Failed:

Tests completed Failed Passed Skipped
24216 13 24203 5804
View the top 3 failed test(s) by shortest run time
tests.tracing.test_unfinished_spans::test_unfinished_spans_sdk_3
Stack Traces | 0.076s run time
tests/tracing/test_unfinished_spans.py:51: in test_unfinished_spans_sdk_3
    assert {"span0"} == spans_by_name.keys()
E   AssertionError: assert {'span0'} == dict_keys(['span0', 'span2'])
E     +{'span0'}
E     -dict_keys(['span0', 'span2'])
E     Full diff:
E     - dict_keys(['span0', 'span2'])
E     + {'span0'}
tests.tracing.test_unfinished_spans::test_unfinished_spans_sdk_3
Stack Traces | 0.076s run time
tests/tracing/test_unfinished_spans.py:51: in test_unfinished_spans_sdk_3
    assert {"span0"} == spans_by_name.keys()
E   AssertionError: assert {'span0'} == dict_keys(['span0', 'span2'])
E     +{'span0'}
E     -dict_keys(['span0', 'span2'])
E     Full diff:
E     - dict_keys(['span0', 'span2'])
E     + {'span0'}
tests.tracing.test_unfinished_spans::test_unfinished_spans_sdk_3
Stack Traces | 0.079s run time
tests/tracing/test_unfinished_spans.py:51: in test_unfinished_spans_sdk_3
    assert {"span0"} == spans_by_name.keys()
E   AssertionError: assert {'span0'} == dict_keys(['span0', 'span2'])
E     +{'span0'}
E     -dict_keys(['span0', 'span2'])
E     Full diff:
E     - dict_keys(['span0', 'span2'])
E     + {'span0'}

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant