Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coerce None values into strings in logentry params. #4121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

antonpirker
Copy link
Member

Nice rendering of log messages containing parameters that are None values does not work. There we coerce None values into strings to have nicer messages in Sentry UI.

Fixes #3660

@antonpirker antonpirker self-assigned this Mar 6, 2025
Copy link

codecov bot commented Mar 6, 2025

❌ 13 Tests Failed:

Tests completed Failed Passed Skipped
23698 13 23685 5840
View the top 3 failed test(s) by shortest run time
tests.integrations.logging.test_logging test_custom_log_level_names
Stack Traces | 0.006s run time
.../integrations/logging/test_logging.py:155: in test_custom_log_level_names
    assert events[0]["logentry"]["params"] == [logging_level]
E   AssertionError: assert ['10'] == [10]
E     
E     At index 0 diff: '10' != 10
E     
E     Full diff:
E       [
E     -     10,
E     +     '10',
E     ?     +  +
E       ]
tests.integrations.logging.test_logging test_custom_log_level_names
Stack Traces | 0.006s run time
.../integrations/logging/test_logging.py:155: in test_custom_log_level_names
    assert events[0]["logentry"]["params"] == [logging_level]
E   AssertionError: assert ['10'] == [10]
E     
E     At index 0 diff: '10' != 10
E     
E     Full diff:
E       [
E     -     10,
E     +     '10',
E     ?     +  +
E       ]
tests.integrations.logging.test_logging test_custom_log_level_names
Stack Traces | 0.006s run time
.../integrations/logging/test_logging.py:155: in test_custom_log_level_names
    assert events[0]["logentry"]["params"] == [logging_level]
E   AssertionError: assert ['10'] == [10]
E     
E     At index 0 diff: '10' != 10
E     
E     Full diff:
E       [
E     -     10,
E     +     '10',
E     ?     +  +
E       ]

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging message is unrendered on a webhook call
1 participant