Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FastAPI/Starlette middleware with positional arguments. #4118

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

antonpirker
Copy link
Member

Fixes #3246

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.59%. Comparing base (8672dc1) to head (63b25d9).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/starlette.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4118      +/-   ##
==========================================
+ Coverage   79.56%   79.59%   +0.02%     
==========================================
  Files         140      140              
  Lines       15581    15581              
  Branches     2643     2643              
==========================================
+ Hits        12397    12401       +4     
+ Misses       2345     2343       -2     
+ Partials      839      837       -2     
Files with missing lines Coverage Δ
sentry_sdk/integrations/starlette.py 84.09% <66.66%> (ø)

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError when instantiating Starlette middleware with positional arguments
2 participants