Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a script to populate parts of tox.ini #3920
Use a script to populate parts of tox.ini #3920
Changes from 1 commit
f54a018
9c829da
c365900
cb7a0aa
51de6a2
33e66b2
153bae2
d4d44b1
fbe73b8
6c2edd0
7470a9b
16a4ba2
ec3d9cb
04a2ab6
b44f195
a1e7da7
8345859
971d4ab
fe62214
15fa2d2
e0e6b20
e14f2c4
b8d29b3
c6f1c65
97a7ae7
875fa6e
7ed6109
5c05100
267dc07
5cff258
e392825
30effcf
912c981
7d45cc6
6d0ab22
f60018e
c4dab11
1068830
67502e7
91ea137
fcfb731
37d0e25
a96e1a4
ef0af89
b37519b
659d859
f23c8be
e330704
26638a5
bb4c84e
beb2271
dca044e
9f2ce18
9c45ece
dd2a531
6927592
1ae16bf
6176ea5
b17e51d
6ef2e19
82b8a60
0adedc7
b0a0772
d7721ad
057a1dc
5b9da4b
10f96a7
26fcd99
ce869ec
d9eead4
e54e888
8b11b74
feca999
975862c
5524412
d6b4257
386d4ef
0bf2a2b
64ced2f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider formalizing these formats as TypedDicts, or by using some other structured data type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do this in a follow up PR, might be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should pin these to specific versions to avoid breaking the script in the event of a breaking change in these packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine to leave as is. We're only using very basic public APIs. If anything changes we can pin the version then.