Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove init context manager #3730

Merged

Conversation

szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex commented Nov 5, 2024

BREAKING CHANGE: sentry_sdk.init now returns None instead of a context manager.

Closes #3727

It is possible to use the return value of `sentry_sdk.init` as a context manager; however, this functionality has not been maintained for a long time, and it does not seem to be documented anywhere.

So, we are deprecating this functionality, and we will remove it in the next major release.

Closes #3282
BREAKING CHANGE: `sentry_sdk.init` now returns `None` instead of a context manager.
@szokeasaurusrex szokeasaurusrex changed the title szokeasaurusrex/remove init context manager Remove init context manager Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

❌ 1788 Tests Failed:

Tests completed Failed Passed Skipped
19714 1788 17926 4416
View the top 3 failed tests by shortest run time
tests.integrations.litestar.test_litestar test_middleware_callback_spans
Stack Traces | 0s run time
No failure message available
tests.integrations.litestar.test_litestar test_middleware_callback_spans
Stack Traces | 0s run time
No failure message available
tests.integrations.litestar.test_litestar test_middleware_partial_receive_send
Stack Traces | 0s run time
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@szokeasaurusrex
Copy link
Member Author

This PR should be merged with a rebase to prevent merge conflicts when updating potel-base from master.

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

@szokeasaurusrex szokeasaurusrex merged commit e7218da into potel-base Nov 5, 2024
24 of 125 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/remove-init-context-manager branch November 5, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants