feat(aws): Add SENTRY_LAYER_EXTENSION to configure using the lambda layer extension via env variables
#18101
+124
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Nov 5, 2025
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
LGTM! Two minor nits, both optional :)
Comment on lines
443
to
472
| test('should support various falsy values (0, no, off)', () => { | ||
| const falsyValues = ['0', 'no', 'off', 'n', 'f']; | ||
|
|
||
| falsyValues.forEach(value => { | ||
| mockGetSDKSource.mockReturnValue('aws-lambda-layer'); | ||
| process.env.SENTRY_LAYER_EXTENSION = value; | ||
|
|
||
| init({}); | ||
|
|
||
| expect(mockInitWithoutDefaultIntegrations).toHaveBeenCalledWith( | ||
| expect.objectContaining({ | ||
| useLayerExtension: false, | ||
| }), | ||
| ); | ||
| }); | ||
| }); | ||
|
|
||
| test('should fall back to default behavior when SENTRY_LAYER_EXTENSION is not set', () => { | ||
| mockGetSDKSource.mockReturnValue('aws-lambda-layer'); | ||
| const options: AwsServerlessOptions = {}; | ||
|
|
||
| init(options); | ||
|
|
||
| expect(mockInitWithoutDefaultIntegrations).toHaveBeenCalledWith( | ||
| expect.objectContaining({ | ||
| useLayerExtension: true, | ||
| tunnel: 'http://localhost:9000/envelope', | ||
| }), | ||
| ); | ||
| }); |
Member
There was a problem hiding this comment.
l: no strong opinion so feel free to ignore but: I don't think we necessarily need to test this here, since (hopefully) envToBool already covers this. The test obviously doesn't hurt but wdyt about converting it to it.each if we keep it? This would make it clear which case fails which we don't see with the current implementation.
Member
Author
There was a problem hiding this comment.
Right, I removed the ones that basically just test envToBool but kept some of the other ones. I kept them as is, not via test.each because it seemed harder to follow when I tried that.
… layer extension via env variables
Co-authored-by: Lukas Stracke <[email protected]>
andreiborza
force-pushed
the
ab/use-layer-extension-env-variable
branch
from
b9bf109 to
f72dc76
Compare
andreiborza
commented
Nov 5, 2025
Member
Author
andreiborza
left a comment
andreiborza
left a comment
There was a problem hiding this comment.
I reworked the logic a bit to make sure the tunnel is only set when it's feasible (i.e. aws layer + no prior tunnel + no proxy) and cleaned up the warnings around this a bit.
Contributor
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our recommended approach for the aws sdk is to use our Lambda layer. When the Lambda layer is used, it would previously automatically set up the layer extension. This can be disabled by setting
useLayerExtension: falseduring init, but when using the layer with our auto-wrapping as per recommendation, it wasn't possible to opt out of using the extension.This PR adds
SENTRY_LAYER_EXTENSIONthat can be used to opt out of the extension.