Skip to content

test(astro): Add E2E test case for catch-all routes #17085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Jul 18, 2025

Extracting a test case in a new PR while working on route parametrization.

Continuation of #17054

Part of #16686

@s1gr1d s1gr1d requested review from RulaKhaled and andreiborza July 18, 2025 11:55
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Astro Catch-All Route Naming Issue

The test for Astro catch-all routes ([...path].astro) incorrectly expects the server transaction name to be 'GET /catchAll/[path]'. It should be 'GET /catchAll/[...path]' to correctly reflect the catch-all route parametrization, as also suggested by a todo comment in the test.

dev-packages/e2e-tests/test-applications/astro-5/tests/tracing.dynamic.test.ts#L296-L297

expect(serverPageRequestTxn).toMatchObject({
transaction: 'GET /catchAll/[path]',

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants