feat: Avoid usage of any
#17041
Open
feat: Avoid usage of any
#17041
+118
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
chargome
approved these changes
Jul 16, 2025
| @@ -380,7 +382,11 @@ function instrumentPostgRESTFilterBuilder(PostgRESTFilterBuilder: PostgRESTFilte | |||
| } | |||
|
|
|||
| if (Object.keys(body).length) { | |||
| attributes['db.body'] = body; | |||
| try { | |||
| attributes['db.body'] = JSON.stringify(body); | |||
There was a problem hiding this comment.
q: Did this get stringified anyway before or why are we doing it now?
There was a problem hiding this comment.
not sure if this ever worked, but OTEL does not support complex attributes. Maybe it kind-of worked because we accept this in our transaction event, but this is the more safe/correct solution IMHO!
| @@ -47,4 +47,5 @@ export interface Integration { | |||
| * An integration in function form. | |||
| * This is expected to return an integration. | |||
| */ | |||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
There was a problem hiding this comment.
this sadly does not work, there are some incompatibilites with function arguments and unknown, sometimes...
This makes the lint rule error, instead of warn, and gets rid of some more any usage. Some of that may technically be breaking because the types can be exposed, but this should be very unlikely to affect any users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the lint rule error, instead of warn, and gets rid of some more any usage. Some of that may technically be breaking because the types can be exposed, but this should be very unlikely to affect any users.
In a future version of eslint, this is on by default, but IMHO it makes sense for us anyhow - any should only be used when absolutely necessary and when we make a conscious choice to do so.