fix(remix): Avoid rewrapping root loader. #16136
Open
+22
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurtemizkan
force-pushed
the
onur/remix-avoid-root-loader-rewrap
branch
from
62c38cc to
c0a0312
Compare
onurtemizkan
commented
Apr 25, 2025
| @@ -40,7 +40,6 @@ test('Sends two linked transactions (server & client) to Sentry', async ({ page | |||
|
|
|||
| const httpServerTraceId = httpServerTransaction.contexts?.trace?.trace_id; | |||
| const httpServerSpanId = httpServerTransaction.contexts?.trace?.span_id; | |||
| const loaderSpanId = httpServerTransaction?.spans?.find(span => span.op === 'function.remix.loader')?.span_id; | |||
There was a problem hiding this comment.
There was a loader span here, and not anymore. This was probably a result of unnecessary rewrapping. And that span didn't contribute to the span linking on Hydrogen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #16075
We used to allow rewrapping of the root loader when we had a separate Express adapter, where we could not determine the instrumentation order. Now that we don't have it anymore, we can remove this. Still, can't reproduce the original issue running e2e test apps under load. But it's clear that's what caused it.