Skip to content

feat(nuxt): Add Cloudflare Nitro plugin #15597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions packages/cloudflare/src/request.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ import {
captureException,
continueTrace,
flush,
getCurrentScope,
getHttpSpanDetailsFromUrlObject,
getTraceData,
parseStringToURLObject,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
setHttpStatus,
Expand Down Expand Up @@ -69,6 +71,40 @@ export function wrapRequestHandler(
}
}

// fixme: at this point, there is no active span

// Check if we already have active trace data - if so, don't wrap with continueTrace
// This allows us to continue an existing trace from the parent context (e.g., Nuxt)
// todo: create an option for opting out of continueTrace
const existingPropagationContext = getCurrentScope().getPropagationContext();
if (existingPropagationContext?.traceId) {
return startSpan(
{
name,
attributes,
},
async span => {
// fixme: same as 2
console.log('::traceData 2', getTraceData());
console.log('::propagationContext 2', JSON.stringify(getCurrentScope().getPropagationContext()));

try {
const res = await handler();
setHttpStatus(span, res.status);
return res;
} catch (e) {
captureException(e, { mechanism: { handled: false, type: 'cloudflare' } });
throw e;
} finally {
context?.waitUntil(flush(2000));
}
},
);
}

console.log('request.headers', request.headers);

// No active trace, create one from headers
return continueTrace(
{ sentryTrace: request.headers.get('sentry-trace') || '', baggage: request.headers.get('baggage') },
() => {
Expand All @@ -81,6 +117,9 @@ export function wrapRequestHandler(
attributes,
},
async span => {
console.log('::traceData 3', getTraceData());
console.log('::propagationContext 3', JSON.stringify(getCurrentScope().getPropagationContext()));

try {
const res = await handler();
setHttpStatus(span, res.status);
Expand Down
5 changes: 5 additions & 0 deletions packages/nuxt/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@
"types": "./build/module/types.d.ts",
"import": "./build/module/module.mjs",
"require": "./build/module/module.cjs"
},
"./module/plugins": {
"types": "./build/module/runtime/plugins/index.d.ts",
"import": "./build/module/runtime/plugins/index.js"
}
},
"publishConfig": {
Expand All @@ -45,6 +49,7 @@
"@nuxt/kit": "^3.13.2",
"@sentry/browser": "9.26.0",
"@sentry/core": "9.26.0",
"@sentry/cloudflare": "9.26.0",
"@sentry/node": "9.26.0",
"@sentry/opentelemetry": "9.26.0",
"@sentry/rollup-plugin": "3.4.0",
Expand Down
47 changes: 47 additions & 0 deletions packages/nuxt/src/runtime/hooks/captureErrorHook.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
import { captureException, getClient, getCurrentScope } from '@sentry/core';
// eslint-disable-next-line import/no-extraneous-dependencies
import { H3Error } from 'h3';
import type { CapturedErrorContext } from 'nitropack';
import { extractErrorContext, flushIfServerless } from '../utils';

/**
* Hook that can be added in a Nitro plugin. It captures an error and sends it to Sentry.
*/
export async function sentryCaptureErrorHook(error: Error, errorContext: CapturedErrorContext): Promise<void> {
const sentryClient = getClient();
const sentryClientOptions = sentryClient?.getOptions();

if (
sentryClientOptions &&
'enableNitroErrorHandler' in sentryClientOptions &&
sentryClientOptions.enableNitroErrorHandler === false
) {
return;
}

// Do not handle 404 and 422
if (error instanceof H3Error) {
// Do not report if status code is 3xx or 4xx
if (error.statusCode >= 300 && error.statusCode < 500) {
return;
}
}

const { method, path } = {
method: errorContext.event?._method ? errorContext.event._method : '',
path: errorContext.event?._path ? errorContext.event._path : null,
};

if (path) {
getCurrentScope().setTransactionName(`${method} ${path}`);
}

const structuredContext = extractErrorContext(errorContext);

captureException(error, {
captureContext: { contexts: { nuxt: structuredContext } },
mechanism: { handled: false },
});

await flushIfServerless();
}
2 changes: 2 additions & 0 deletions packages/nuxt/src/runtime/plugins/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
// fixme: Can this be exported like this?
export { sentryCloudflareNitroPlugin } from './sentry-cloudflare.server';
147 changes: 147 additions & 0 deletions packages/nuxt/src/runtime/plugins/sentry-cloudflare.server.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,147 @@
import type { ExecutionContext } from '@cloudflare/workers-types';
import type { CloudflareOptions } from '@sentry/cloudflare';
import {
getActiveSpan,
getTraceData,
setAsyncLocalStorageAsyncContextStrategy,
spanToJSON,
wrapRequestHandler,
} from '@sentry/cloudflare';
import { continueTrace, getCurrentScope, getDefaultIsolationScope, getIsolationScope, logger } from '@sentry/core';
import type { H3Event } from 'h3';
import type { NitroApp, NitroAppPlugin } from 'nitropack';
import type { NuxtRenderHTMLContext } from 'nuxt/app';
import { sentryCaptureErrorHook } from '../hooks/captureErrorHook';
import { addSentryTracingMetaTags } from '../utils';

interface CfEventType {
protocol: string;
host: string;
context: {
cloudflare: {
context: ExecutionContext;
};
};
}

function isEventType(event: unknown): event is CfEventType {
return (
event !== null &&
typeof event === 'object' &&
'protocol' in event &&
'host' in event &&
'context' in event &&
typeof event.protocol === 'string' &&
typeof event.host === 'string' &&
typeof event.context === 'object' &&
event?.context !== null &&
'cloudflare' in event.context &&
typeof event.context.cloudflare === 'object' &&
event?.context.cloudflare !== null &&
'context' in event?.context?.cloudflare
);
}

/**
* Sentry Cloudflare Nitro plugin for when using the "cloudflare-pages" preset in Nuxt.
* This plugin automatically sets up Sentry error monitoring and performance tracking for Cloudflare Pages projects.
*
* Instead of adding a `sentry.server.config.ts` file, export this plugin in the `server/plugins` directory
* with the necessary Sentry options to enable Sentry for your Cloudflare Pages project.
*
*
* @example Basic usage
* ```ts
* // nitro/plugins/sentry.ts
* import { defineNitroPlugin } from '#imports'
* import { sentryCloudflareNitroPlugin } from '@sentry/nuxt/module/plugins'
*
* export default defineNitroPlugin(sentryCloudflareNitroPlugin({
* dsn: 'https://[email protected]/0',
* tracesSampleRate: 1.0,
* }));
* ```
*
* @example Dynamic configuration with nitroApp
* ```ts
* // nitro/plugins/sentry.ts
* import { defineNitroPlugin } from '#imports'
* import { sentryCloudflareNitroPlugin } from '@sentry/nuxt/module/plugins'
*
* export default defineNitroPlugin(sentryCloudflareNitroPlugin(nitroApp => ({
* dsn: 'https://[email protected]/0',
* debug: nitroApp.h3App.options.debug
* })));
* ```
*/
export const sentryCloudflareNitroPlugin =
(optionsOrFn: CloudflareOptions | ((nitroApp: NitroApp) => CloudflareOptions)): NitroAppPlugin =>
(nitroApp: NitroApp): void => {
nitroApp.localFetch = new Proxy(nitroApp.localFetch, {
async apply(handlerTarget, handlerThisArg, handlerArgs: [string, unknown]) {
setAsyncLocalStorageAsyncContextStrategy();

const sentryOptions = typeof optionsOrFn === 'function' ? optionsOrFn(nitroApp) : optionsOrFn;

const pathname = handlerArgs[0];
const event = handlerArgs[1];

if (isEventType(event)) {
const requestHandlerOptions = {
options: sentryOptions,
request: { ...event, url: `${event.protocol}//${event.host}${pathname}` },
context: event.context.cloudflare.context,
};

// fixme same as 5
console.log('::traceData 1', getTraceData());
console.log('::propagationContext 1', JSON.stringify(getCurrentScope().getPropagationContext()));

const traceData = getTraceData();

// return continueTrace({ sentryTrace: traceData['sentry-trace'] || '', baggage: traceData.baggage }, () => {
return wrapRequestHandler(requestHandlerOptions, () => {
const isolationScope = getIsolationScope();
const newIsolationScope =
isolationScope === getDefaultIsolationScope() ? isolationScope.clone() : isolationScope;

logger.log(
`Patched Cloudflare handler (\`nitroApp.localFetch\`). ${
isolationScope === newIsolationScope ? 'Using existing' : 'Created new'
} isolation scope.`,
);

console.log('::traceData 4', getTraceData());
console.log('::propagationContext 4', JSON.stringify(getCurrentScope().getPropagationContext()));

return handlerTarget.apply(handlerThisArg, handlerArgs);
});
// });
}

return handlerTarget.apply(handlerThisArg, handlerArgs);
},
});

// todo: start span in a hook before the request handler

// @ts-expect-error - 'render:html' is a valid hook name in the Nuxt context
nitroApp.hooks.hook('render:html', (html: NuxtRenderHTMLContext, { event }: { event: H3Event }) => {
// fixme: it's attaching the html meta tag but it's not connecting the trace
// fixme: its' actually connecting the trace but the meta tags are cached
console.log('event.headers', event.headers);
console.log('event.node.req.headers.cache-control', event.node.req.headers['cache-control']);
console.log('event.context', event.context);

const span = getActiveSpan();

console.log('::active span', span ? spanToJSON(span) : 'no active span');

console.log('::traceData 5', getTraceData());
console.log('::propagationContext 5', JSON.stringify(getCurrentScope().getPropagationContext()));

addSentryTracingMetaTags(html.head);
});

nitroApp.hooks.hook('error', sentryCaptureErrorHook);
};
83 changes: 5 additions & 78 deletions packages/nuxt/src/runtime/plugins/sentry.server.ts
Original file line number Diff line number Diff line change
@@ -1,96 +1,23 @@
import {
flush,
getDefaultIsolationScope,
getIsolationScope,
GLOBAL_OBJ,
logger,
vercelWaitUntil,
withIsolationScope,
} from '@sentry/core';
import * as SentryNode from '@sentry/node';
import { getDefaultIsolationScope, getIsolationScope, logger, withIsolationScope } from '@sentry/core';
// eslint-disable-next-line import/no-extraneous-dependencies
import { type EventHandler, H3Error } from 'h3';
import { type EventHandler } from 'h3';
// eslint-disable-next-line import/no-extraneous-dependencies
import { defineNitroPlugin } from 'nitropack/runtime';
import type { NuxtRenderHTMLContext } from 'nuxt/app';
import { addSentryTracingMetaTags, extractErrorContext } from '../utils';
import { sentryCaptureErrorHook } from '../hooks/captureErrorHook';
import { addSentryTracingMetaTags, flushIfServerless } from '../utils';

export default defineNitroPlugin(nitroApp => {
nitroApp.h3App.handler = patchEventHandler(nitroApp.h3App.handler);

nitroApp.hooks.hook('error', async (error, errorContext) => {
const sentryClient = SentryNode.getClient();
const sentryClientOptions = sentryClient?.getOptions();

if (
sentryClientOptions &&
'enableNitroErrorHandler' in sentryClientOptions &&
sentryClientOptions.enableNitroErrorHandler === false
) {
return;
}

// Do not handle 404 and 422
if (error instanceof H3Error) {
// Do not report if status code is 3xx or 4xx
if (error.statusCode >= 300 && error.statusCode < 500) {
return;
}
}

const { method, path } = {
method: errorContext.event?._method ? errorContext.event._method : '',
path: errorContext.event?._path ? errorContext.event._path : null,
};

if (path) {
SentryNode.getCurrentScope().setTransactionName(`${method} ${path}`);
}

const structuredContext = extractErrorContext(errorContext);

SentryNode.captureException(error, {
captureContext: { contexts: { nuxt: structuredContext } },
mechanism: { handled: false },
});

await flushIfServerless();
});
nitroApp.hooks.hook('error', sentryCaptureErrorHook);

// @ts-expect-error - 'render:html' is a valid hook name in the Nuxt context
nitroApp.hooks.hook('render:html', (html: NuxtRenderHTMLContext) => {
addSentryTracingMetaTags(html.head);
});
});

async function flushIfServerless(): Promise<void> {
const isServerless =
!!process.env.FUNCTIONS_WORKER_RUNTIME || // Azure Functions
!!process.env.LAMBDA_TASK_ROOT || // AWS Lambda
!!process.env.VERCEL ||
!!process.env.NETLIFY;

// @ts-expect-error This is not typed
if (GLOBAL_OBJ[Symbol.for('@vercel/request-context')]) {
vercelWaitUntil(flushWithTimeout());
} else if (isServerless) {
await flushWithTimeout();
}
}

async function flushWithTimeout(): Promise<void> {
const sentryClient = SentryNode.getClient();
const isDebug = sentryClient ? sentryClient.getOptions().debug : false;

try {
isDebug && logger.log('Flushing events...');
await flush(2000);
isDebug && logger.log('Done flushing events');
} catch (e) {
isDebug && logger.log('Error while flushing events:\n', e);
}
}

function patchEventHandler(handler: EventHandler): EventHandler {
return new Proxy(handler, {
async apply(handlerTarget, handlerThisArg, handlerArgs: Parameters<EventHandler>) {
Expand Down
Loading