Skip to content

Conversation

@stefanosiano
Copy link
Member

📜 Description

removed SentryExecutorService max queue limit

💡 Motivation and Context

Some critical SDK internal operation depend on our SentryExecutorService, so it's better to avoid losing any scheduled job, or we risk things like #4841

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@stefanosiano stefanosiano marked this pull request as ready for review October 29, 2025 10:44
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 327.98 ms 398.31 ms 70.33 ms
Size 1.58 MiB 2.12 MiB 552.22 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
2124a46 319.19 ms 415.04 ms 95.85 ms
b3d8889 420.46 ms 453.71 ms 33.26 ms
d217708 409.83 ms 474.72 ms 64.89 ms
3d205d0 352.15 ms 432.53 ms 80.38 ms
fcec2f2 357.47 ms 447.32 ms 89.85 ms
889ecea 367.58 ms 437.52 ms 69.94 ms
1df7eb6 397.04 ms 429.64 ms 32.60 ms
ce0a49e 532.00 ms 609.96 ms 77.96 ms
ee747ae 357.79 ms 421.84 ms 64.05 ms
b750b96 408.98 ms 480.32 ms 71.34 ms

App size

Revision Plain With Sentry Diff
2124a46 1.58 MiB 2.12 MiB 551.51 KiB
b3d8889 1.58 MiB 2.10 MiB 535.07 KiB
d217708 1.58 MiB 2.10 MiB 532.97 KiB
3d205d0 1.58 MiB 2.10 MiB 532.97 KiB
fcec2f2 1.58 MiB 2.12 MiB 551.50 KiB
889ecea 1.58 MiB 2.11 MiB 539.75 KiB
1df7eb6 1.58 MiB 2.10 MiB 532.97 KiB
ce0a49e 1.58 MiB 2.10 MiB 532.94 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
b750b96 1.58 MiB 2.10 MiB 533.19 KiB

Previous results on branch: stefanosiano/fix/remove-executor-service-limit

Startup times

Revision Plain With Sentry Diff
01d0a7e 323.23 ms 389.35 ms 66.12 ms
42b3e9b 322.84 ms 365.04 ms 42.20 ms

App size

Revision Plain With Sentry Diff
01d0a7e 1.58 MiB 2.12 MiB 551.16 KiB
42b3e9b 1.58 MiB 2.12 MiB 551.16 KiB

…-service-limit' into stefanosiano/fix/remove-executor-service-limit
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@romtsn romtsn enabled auto-merge (squash) November 5, 2025 09:41

### Fixes

- Removed SentryExecutorService limit for delayed scheduled tasks ([#4846](https://github.com/getsentry/sentry-java/pull/4846))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 🚫 The changelog entry seems to be part of an already released section ## 8.25.0.
    Consider moving the entry to the ## Unreleased section, please.

@romtsn romtsn merged commit afd4170 into main Nov 5, 2025
60 of 62 checks passed
@romtsn romtsn deleted the stefanosiano/fix/remove-executor-service-limit branch November 5, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants