Skip to content

Conversation

stefanosiano
Copy link
Member

📜 Description

added session replay id to logs, if a replay is running

💡 Motivation and Context

Resolves https://linear.app/getsentry/issue/ANDROID-210/add-sentryreplay-id-to-android-logs

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link

linear bot commented Sep 19, 2025

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 412.76 ms 475.58 ms 62.82 ms
Size 1.58 MiB 2.10 MiB 533.00 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
674d437 355.28 ms 504.18 ms 148.90 ms
ee747ae 374.71 ms 455.18 ms 80.47 ms
ee747ae 400.46 ms 423.61 ms 23.15 ms
ce0a49e 532.00 ms 609.96 ms 77.96 ms
ee747ae 357.79 ms 421.84 ms 64.05 ms
3699cd5 423.60 ms 495.52 ms 71.92 ms
3d205d0 352.15 ms 432.53 ms 80.38 ms
ee747ae 396.82 ms 441.67 ms 44.86 ms
23d6b12 354.10 ms 408.38 ms 54.28 ms
1df7eb6 397.04 ms 429.64 ms 32.60 ms

App size

Revision Plain With Sentry Diff
674d437 1.58 MiB 2.10 MiB 530.94 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ce0a49e 1.58 MiB 2.10 MiB 532.94 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
3699cd5 1.58 MiB 2.10 MiB 533.45 KiB
3d205d0 1.58 MiB 2.10 MiB 532.97 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
23d6b12 1.58 MiB 2.10 MiB 532.31 KiB
1df7eb6 1.58 MiB 2.10 MiB 532.97 KiB

@stefanosiano stefanosiano marked this pull request as ready for review September 19, 2025 13:02
cursor[bot]

This comment was marked as outdated.

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still a bit unclear how to handle it properly with edge-cases (e.g. buffered replay not being sent), let's follow the internal thread and implement this properly after that: https://sentry.slack.com/archives/C03USURCFBJ/p1758210278868829

@stefanosiano stefanosiano marked this pull request as draft September 19, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants