Skip to content

Conversation

lcian
Copy link
Member

@lcian lcian commented Aug 26, 2025

📜 Description

Work around fossas/fossa-cli#872 by disabling the configuration cache for this specific workflow.
We need to do it this way because gradle.properties has precedence over environment variables.
Close #4526
#skip-changelog

Copy link
Contributor

github-actions bot commented Aug 26, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 378.77 ms 438.81 ms 60.05 ms
Size 1.58 MiB 2.10 MiB 533.19 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ee747ae 382.73 ms 435.41 ms 52.68 ms
ee747ae 415.92 ms 470.15 ms 54.23 ms
ee747ae 400.46 ms 423.61 ms 23.15 ms
ee747ae 554.98 ms 611.50 ms 56.52 ms
ee747ae 358.21 ms 389.41 ms 31.20 ms
3699cd5 423.60 ms 495.52 ms 71.92 ms
85d7417 347.21 ms 394.35 ms 47.15 ms
7314dbe 437.83 ms 505.64 ms 67.81 ms
ee747ae 357.79 ms 421.84 ms 64.05 ms
ee747ae 374.71 ms 455.18 ms 80.47 ms

App size

Revision Plain With Sentry Diff
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
3699cd5 1.58 MiB 2.10 MiB 533.45 KiB
85d7417 1.58 MiB 2.10 MiB 533.44 KiB
7314dbe 1.58 MiB 2.10 MiB 533.45 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB

Previous results on branch: lcian/ci/fix-fossa

Startup times

Revision Plain With Sentry Diff
1c3b39c 402.00 ms 446.20 ms 44.20 ms
59484c4 390.69 ms 445.80 ms 55.10 ms
97fe0b3 387.54 ms 443.76 ms 56.21 ms
2731dd9 396.40 ms 462.02 ms 65.63 ms
c33a96b 402.36 ms 459.46 ms 57.10 ms
3ac0c81 385.10 ms 436.52 ms 51.42 ms
e9ed27a 381.22 ms 427.04 ms 45.82 ms
87902f7 418.45 ms 494.39 ms 75.94 ms
70faeb6 398.34 ms 471.14 ms 72.80 ms
623b30c 398.30 ms 471.78 ms 73.48 ms

App size

Revision Plain With Sentry Diff
1c3b39c 1.58 MiB 2.10 MiB 533.45 KiB
59484c4 1.58 MiB 2.10 MiB 533.45 KiB
97fe0b3 1.58 MiB 2.10 MiB 533.44 KiB
2731dd9 1.58 MiB 2.10 MiB 533.44 KiB
c33a96b 1.58 MiB 2.10 MiB 533.44 KiB
3ac0c81 1.58 MiB 2.10 MiB 533.44 KiB
e9ed27a 1.58 MiB 2.10 MiB 533.44 KiB
87902f7 1.58 MiB 2.10 MiB 533.45 KiB
70faeb6 1.58 MiB 2.10 MiB 533.45 KiB
623b30c 1.58 MiB 2.10 MiB 533.43 KiB

@lcian lcian changed the title Disable Gradle configuration cache for enforce-license-compliance workflow Update "Enforce License Compliance" workflow Aug 27, 2025
@lcian lcian marked this pull request as ready for review August 27, 2025 07:46
cursor[bot]

This comment was marked as outdated.

@lcian lcian enabled auto-merge (squash) August 29, 2025 07:21
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job! so can we use this action to detect licence violations in source files?

@lcian
Copy link
Member Author

lcian commented Sep 5, 2025

nice job! so can we use this action to detect licence violations in source files?

Apparently this works only for Gradle dependencies.
For vendored dependencies, you would have to create a .fossa.yml to point the tool to them.
Even then (I've tried), it seems those are not detected reliably.
We can probably use #4680 once it's ready, it's a simple grep that should work for vendored deps.

@lcian lcian merged commit d611745 into main Sep 5, 2025
44 checks passed
@lcian lcian deleted the lcian/ci/fix-fossa branch September 5, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enforce-license-compliance check cannot find analysis targets
2 participants