Extend Logs API to allow passing in attributes
#4402
Conversation
adinauer
requested review from
romtsn,
stefanosiano,
markushi and
lcian
as code owners
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Extend Logs API to allow passing in `attributes` ([#4402](https://github.com/getsentry/sentry-java/pull/4402))If none of the above apply, you can opt out of this check by adding |
Performance metrics 🚀
|
| } | ||
|
|
||
| @SuppressWarnings("AnnotateFormatMethod") | ||
| private void captureLog( | ||
| final @Nullable Map<String, Object> attributes, |
There was a problem hiding this comment.
I don't like it too much that it's the first param but I guess it must be like this because of the varargs right?
There was a problem hiding this comment.
I would like it more for this to be the last param but I don't think that's possible. Either way it's fine, I would expect most users to not go through this API
lcian
force-pushed
the
feat/logs-attributes-in-api
branch
from
3a26d0a to
5ca032d
Compare
|
Sorry pushed on this branch by mistake, should be restored, please double check |
| final @NotNull HashMap<String, SentryLogEventAttributeValue> attributes = new HashMap<>(); | ||
|
|
||
| if (incomingAttributes != null) { |
There was a problem hiding this comment.
Should we create a copy of the attributes (here or in the capture method) to avoid having a map that could be changed while we iterate on it?
📜 Description
Extend Logs API to allow passing in
attributes💡 Motivation and Context
Filtering Logs in Sentry via custom attributes.
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps