Continuous Profiling - Add delayed stop #4293
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added platform "android" in ProfileChunk envelope items
…dContinuousProfiler Added "delayed" stop of profiler, which stops the profiler after the current chunk is finished Added default span data (profiler id, thread name and thread id) to transaction root span
|
stefanosiano
requested review from
adinauer,
romtsn,
markushi and
lcian
as code owners
Performance metrics 🚀
|
7 tasks
markushi
approved these changes
Apr 4, 2025
| } | ||
| } | ||
|
|
||
| public synchronized void reevaluateSampling() { | ||
| public void reevaluateSampling() { | ||
| shouldSample = true; |
There was a problem hiding this comment.
any thread could cause a write here, right? If so, we should mark the field as volatile.
There was a problem hiding this comment.
yeah, but it's a value that is evaluated after a while, and not even a problem if it's skipped the first time.
This way we can skip the overhead of volatile
wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Replaced synchronized blocks with AutoClosableReentrantLock in AndroidContinuousProfiler - unrelated to delayed stop, but small enough to be added in this PR
Added "delayed" stop of profiler, which stops the profiler after the current chunk is finished
Added default span data (profiler id, thread name and thread id) to transaction root span - unrelated to delayed stop, but this was causing the
ui.loadspan to not have the thread id and thread name attached, breaking the link to the continuous profile. A fix is already deployed on the frontend, which fallbacks to the main thread in such cases, but we should still fix it anyway in the SDK💡 Motivation and Context
The goal of continuous profiling is to send profile chunks 1 minute long, as it's more efficient to store few large chunks than multiple small chunks. To avoid the case when a profiler is started and stopped multiple times in the minute time range, causing multiple small chunks to be captured, we now wait until the chunk is finished to stop the profiler.
Note: closing the SDK through
Sentry.close()doesn't wait anything💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps