-
-
Notifications
You must be signed in to change notification settings - Fork 12
feat: Add logs from SentrySDK.logger to Godot output #463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Could we reuse the (pretty sure we still need this in Native too 😅 ) |
|
@JoshuaMoelans Sure, we can do that. But that means we’ll be mixing log output with Sentry’s debug output. And those aren’t the same things. If someone wants to see log entries in the Godot console (90% need this - should be default), they might not necessarily want all the other internal details of Sentry operations. |
This PR adds an option to print logs added with
SentrySDK.loggerAPI to Godot console (and as such tostdout/err). And this option is enabled by default.While testing Logs API in my project, I noticed that I very much lacked logs being printed to the Godot's console. This is not a problem when you use Godot's standard logging functions such as
print()andprinterr. Only when using our dedicated API like so:So it makes the most sense to me if the logs from our API would also appear in the console in addition to being sent to Sentry. The option is added in case this behavior is not desired on particular projects.