- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.6k
feat(python): Document metrics #15299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| The latest updates on your projects. Learn more about Vercel for GitHub. 
 1 Skipped Deployment
 | 
| Bundle ReportChanges will increase total bundle size by 52.33kB (0.22%) ⬆️. This is within the configured threshold ✅ Detailed changes
 Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
 view changes for bundle: sentry-docs-client-array-pushAssets Changed:
 view changes for bundle: sentry-docs-edge-server-array-pushAssets Changed:
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall, but please see comments
| sidebar_title: Metrics | ||
| description: "Metrics allow you to send, view and query counters, gauges and measurements sent from your applications within Sentry." | ||
| sidebar_order: 5755 | ||
| --- | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have a notice here that is still in beta, maybe tell folks how to apply for the open beta.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, added!
|  | ||
| <Alert> | ||
|  | ||
| This feature is currently in limited beta. Please reach out on [GitHub](https://github.com/getsentry/sentry-python/discussions/5042) if you have feedback or questions. Features in beta are still in-progress and may have bugs. We recognize the irony. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference between limited beta and beta?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are in a limited beta right now, users can only see metrics in their Sentry if a feature flag is turned on for their Sentry organization.
| @@ -0,0 +1,36 @@ | |||
| #### before_send_metric | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this should link to the options doc, and this option should be added to it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The organization is based on the logs documentation.
Currently we do not have experimental options in the options page, so I will keep it here for now. But I agree that we could document experimental options as well and link to them in other pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a suggestion to add the option to the options page
DESCRIBE YOUR PR
Document getsentry/sentry-python#4898
Based on the spec #15178
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES