Skip to content

Conversation

philprime
Copy link
Member

@philprime philprime commented Oct 14, 2025

DESCRIBE YOUR PR

Adds a warning to the Apple docs for Session Replay explaining why session replay is disabled starting with Cocoa SDK 8.57.0

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.): asap - important warning/info
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Oct 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Oct 21, 2025 8:14am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Oct 21, 2025 8:14am

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

@codeowner-assignment codeowner-assignment bot requested a review from a team October 14, 2025 14:18
@philprime philprime changed the title feat(apple): Add warning for disabled with iOS 26.0 Liquid Glass feat(apple): Add warning for session replay disabled with iOS 26.0 Liquid Glass Oct 14, 2025
@philprime philprime marked this pull request as ready for review October 14, 2025 14:18
@codecov
Copy link

codecov bot commented Oct 14, 2025

Bundle Report

Changes will increase total bundle size by 2.27kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.16MB 1.93kB (0.02%) ⬆️
sentry-docs-server-cjs 12.98MB 345 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
../app/[[...path]]/page.js.nft.json 101 bytes 858.71kB 0.01%
../app/platform-redirect/page.js.nft.json 101 bytes 858.62kB 0.01%
../app/sitemap.xml/route.js.nft.json 101 bytes 855.85kB 0.01%
4873.js 51 bytes 91.45kB 0.06%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/css/*.css 1.94kB 748.29kB 0.26%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
server/middleware-*.js 6.46kB 7.46kB 645.5% ⚠️
server/middleware-*.js -6.46kB 1.0kB -86.59%
static/q5OTANneSvqeR41yLu1I0/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/q5OTANneSvqeR41yLu1I0/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/BVTNqo_GFtVfGL44-*.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/BVTNqo_GFtVfGL44-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Contributor

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one suggestion, otherwise lgtm

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a few comments. Thanks @philprime

antonis added a commit that referenced this pull request Oct 20, 2025
<!-- Use this checklist to make sure your PR is ready for merge. You may
delete any sections you don't need. -->

## DESCRIBE YOUR PR
*Tell us what you're changing and why. If your PR **resolves an issue**,
please link it so it closes automatically.*
Adds Liquid Glass PII warning following up to
#15201

## IS YOUR CHANGE URGENT?  

Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [ ] None: Not urgent, can wait up to 1 week+

## SLA

- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!

## PRE-MERGE CHECKLIST

*Make sure you've checked the following before merging your changes:*

- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)

## LEGAL BOILERPLATE

<!-- Sentry employees and contractors can delete or ignore this section.
-->

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.

## EXTRA RESOURCES

- [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
Copy link
Contributor

@sfanahata sfanahata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, but adding titles to those warnings could help clarify their purposes, especially since they'r back to back.

@codeowner-assignment codeowner-assignment bot requested a review from a team October 21, 2025 07:41
@philprime philprime merged commit ca3bdcf into master Oct 21, 2025
13 checks passed
@philprime philprime deleted the philprime/session-replay-disable branch October 21, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants