Skip to content

Remove note about 40M SourceMap Limit #13499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

Conversation

Swatinem
Copy link
Member

Noone can point to where such a limit is actually defined if we indeed have one.

At least for the supported sentry-cli based SourceMap upload flow. It is quite possible that the 40M limit refers to the legacy "single release file upload" endpoints which are deprecated and rarely used, and we would rather work towards removing those endpoints altogether.


While working on this, I noticed that the 3 files I touched are pretty much ~90% the same. I don’t know enough about the docs to maybe work towards merging those pages, so I didn’t touch that.

Noone can point to where such a limit is actually defined if we indeed have one.

At least for the supported `sentry-cli` based SourceMap upload flow.
It is quite possible that the 40M limit refers to the legacy "single release file upload" endpoints which are deprecated and rarely used, and we would rather work towards removing those endpoints altogether.
Copy link

vercel bot commented Apr 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 2:01pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Apr 24, 2025 2:01pm
develop-docs ⬜️ Ignored (Inspect) Apr 24, 2025 2:01pm

@Swatinem Swatinem self-assigned this Apr 24, 2025
@Swatinem Swatinem requested a review from lforst April 24, 2025 13:46
Copy link

codecov bot commented Apr 24, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.14MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/K6ZjSvcKDqYVilP0mn0sq/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/K6ZjSvcKDqYVilP0mn0sq/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/rb2YaSLd-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/rb2YaSLd-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️

@loewenheim
Copy link
Contributor

Thanks for taking care of this. We do have a customer claiming to run into this limit though, we should make sure that's cleared up before undocumenting it.

@Swatinem Swatinem merged commit 22e9c7d into master Apr 28, 2025
15 checks passed
@Swatinem Swatinem deleted the swatinem/rm-40m-limit branch April 28, 2025 10:49
codyde added a commit that referenced this pull request Apr 29, 2025
* 'master' of https://github.com/getsentry/sentry-docs:
  fix(native): add another `crashpad` benefit on macOS to the backend tradeoffs (#13535)
  chore(develop): Update frontend router testing guidance (#13538)
  Bump API schema to 1bf27325 (#13537)
  Fix HTTP headers section in data collected for Java and Android SDK (#13530)
  Add "Data Collected" page for Unreal Engine SDK (#13532)
  feat(seer): Update seer docs (#13448)
  Add an FAQ to trace propagation cheat sheet (#13528)
  Remove note about 40M SourceMap Limit (#13499)
  docs(js): Create SvelteKit Quick Start guide (Wizard setup) (#13480)
  add godot and maui to platforms with screenshot (#13493)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants