-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add close( )
method to Apple drain doc
#13492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
Calling `close()` before exiting the application is critical to avoid data loss. | ||
|
||
After closing, the client cannot be used anymore. It's important to only call | ||
`close()` immediately before shutting down the application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not accurate for the mobile SDKs. Mobile SDKs use an offline cache, and you don't have to call close
before the app exits. All SDKs ensure that no data is lost when the app is put to the background and / or exits. The close method on mobile SDKs exists so users can manually close the SDK. Close shuts down the SDK and tries to send all data to Sentry. Most of the time users don't have to use this.
DESCRIBE YOUR PR
Updating the Apple drain doc to include the
close ( )
method.Liked to #13468
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: