-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apple): Debug session replay masking #12517
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I can't add reviewers. @philipphofmann @philprime |
@brustolin thanks for the ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding 🙏
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
@kahest I went ahead and changed the wording of docs, as well as fixed the naming of the methods. Please review and let me know your feedback |
Bundle ReportChanges will increase total bundle size by 69.22kB (0.35%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a couple suggestions to hopefully make the language a bit simpler. also I think we need to be very explicit about what ppl need to do to ensure no preview is ever shown in prod/release app
Co-authored-by: Karl Heinz Struggl <[email protected]>
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
I checked the source code and AFAIK the |
docs/platforms/apple/guides/ios/session-replay/customredact.mdx
Outdated
Show resolved
Hide resolved
👍 that's what I expected and meant with my comment - we should make it clear to the user that they need to guard it with some |
Seems I like I forgot to merge this after applying the fixes, will do that now. |
Co-authored-by: Philip Niedertscheider <[email protected]> Co-authored-by: Karl Heinz Struggl <[email protected]>
Explain how to debug masking for session replay.