Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apple): Debug session replay masking #12517

Merged
merged 11 commits into from
Feb 28, 2025
Merged

Conversation

brustolin
Copy link
Contributor

Explain how to debug masking for session replay.

Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 1:56pm
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 1:56pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 1:56pm

@brustolin
Copy link
Contributor Author

I can't add reviewers. @philipphofmann @philprime

@philprime
Copy link
Contributor

@brustolin thanks for the ping

Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding 🙏

@philprime philprime self-assigned this Feb 3, 2025
@philprime philprime self-requested a review February 3, 2025 16:53
@philprime philprime requested a review from kahest February 17, 2025 13:54
@philprime
Copy link
Contributor

@kahest I went ahead and changed the wording of docs, as well as fixed the naming of the methods. Please review and let me know your feedback

Copy link

codecov bot commented Feb 17, 2025

Bundle Report

Changes will increase total bundle size by 69.22kB (0.35%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.27MB 69.23kB (0.68%) ⬆️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js 23.08kB 1.48MB 1.58%
../instrumentation.js 23.07kB 814.34kB 2.92%
9523.js 23.08kB 790.54kB 3.01%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.04kB -0.0%
static/chunks/4028-*.js -3 bytes 393.29kB -0.0%
static/x7Vcf9N2og4btP-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/x7Vcf9N2og4btP-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/dUp2O0QPA85Uqo5biglxW/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/dUp2O0QPA85Uqo5biglxW/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple suggestions to hopefully make the language a bit simpler. also I think we need to be very explicit about what ppl need to do to ensure no preview is ever shown in prod/release app

Co-authored-by: Karl Heinz Struggl <[email protected]>
@philprime
Copy link
Contributor

I checked the source code and AFAIK the SentryMaskingPreviewView is not gated for debug/production builds, therefore the responsibility is delegated to the SDK user.

@kahest
Copy link
Member

kahest commented Feb 17, 2025

I checked the source code and AFAIK the SentryMaskingPreviewView is not gated for debug/production builds, therefore the responsibility is delegated to the SDK user.

👍 that's what I expected and meant with my comment - we should make it clear to the user that they need to guard it with some #if DEBUG

@philprime philprime enabled auto-merge (squash) February 28, 2025 13:40
@philprime
Copy link
Contributor

Seems I like I forgot to merge this after applying the fixes, will do that now.

@philprime philprime merged commit ba3bdbb into master Feb 28, 2025
11 checks passed
@philprime philprime deleted the feat(apple)/debug-sr-masking branch February 28, 2025 13:56
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Mobile SDKs Feb 28, 2025
limbonaut pushed a commit that referenced this pull request Feb 28, 2025
Co-authored-by: Philip Niedertscheider <[email protected]>
Co-authored-by: Karl Heinz Struggl <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants